Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5894)

Unified Diff: chrome/browser/sync/sessions/page_revisit_broadcaster.cc

Issue 1399053004: [Sync] Adding revisit logic for typed URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated for Stan's comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sessions/page_revisit_broadcaster.cc
diff --git a/chrome/browser/sync/sessions/page_revisit_broadcaster.cc b/chrome/browser/sync/sessions/page_revisit_broadcaster.cc
index a9c31505bef6198c8380c737e4cb582931ff5d7c..a2973f53e9e10107379fdcb3e874b01657ad5251 100644
--- a/chrome/browser/sync/sessions/page_revisit_broadcaster.cc
+++ b/chrome/browser/sync/sessions/page_revisit_broadcaster.cc
@@ -8,9 +8,13 @@
#include <vector>
#include "base/metrics/field_trial.h"
+#include "chrome/browser/history/history_service_factory.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/glue/synced_session_util.h"
#include "chrome/browser/sync/sessions/sessions_sync_manager.h"
+#include "components/history/core/browser/history_service.h"
#include "components/sync_sessions/revisit/sessions_page_revisit_observer.h"
+#include "components/sync_sessions/revisit/typed_url_page_revisit_observer.h"
namespace browser_sync {
@@ -47,8 +51,13 @@ PageRevisitBroadcaster::PageRevisitBroadcaster(SessionsSyncManager* manager,
scoped_ptr<sync_sessions::ForeignSessionsProvider>(
new SessionsSyncManagerWrapper(manager))));
+ history::HistoryService* history =
+ HistoryServiceFactory::GetForProfileWithoutCreating(profile);
+ if (history) {
+ revisit_observers_.push_back(
+ new sync_sessions::TypedUrlPageRevisitObserver(history));
+ }
// TODO(skym): Add bookmarks observer.
- // TODO(skym): Add typed URL observer.
}
}
« no previous file with comments | « no previous file | components/components_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698