Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: test/cctest/test-heap.cc

Issue 1399033002: Remove FLAG_cache_optimized_code because we always have it on. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-compiler.cc ('k') | test/mjsunit/regress/regress-2193.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index 2cc7add49e6dae475cb6a3fe6435a4a2e12f36c7..8b86544ccbe52577b3871601671ec1c44ccc24bf 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -4319,115 +4319,6 @@ TEST(Regress169928) {
}
-TEST(Regress168801) {
- if (i::FLAG_never_compact) return;
- i::FLAG_always_compact = true;
- i::FLAG_cache_optimized_code = false;
- i::FLAG_allow_natives_syntax = true;
- CcTest::InitializeVM();
- Isolate* isolate = CcTest::i_isolate();
- Heap* heap = isolate->heap();
- HandleScope scope(isolate);
-
- // Perform one initial GC to enable code flushing.
- heap->CollectAllGarbage();
-
- // Ensure the code ends up on an evacuation candidate.
- SimulateFullSpace(heap->code_space());
-
- // Prepare an unoptimized function that is eligible for code flushing.
- Handle<JSFunction> function;
- {
- HandleScope inner_scope(isolate);
- CompileRun("function mkClosure() {"
- " return function(x) { return x + 1; };"
- "}"
- "var f = mkClosure();"
- "f(1); f(2);");
-
- Handle<JSFunction> f =
- v8::Utils::OpenHandle(
- *v8::Handle<v8::Function>::Cast(
- CcTest::global()->Get(v8_str("f"))));
- CHECK(f->is_compiled());
- const int kAgingThreshold = 6;
- for (int i = 0; i < kAgingThreshold; i++) {
- f->shared()->code()->MakeOlder(static_cast<MarkingParity>(i % 2));
- }
-
- function = inner_scope.CloseAndEscape(handle(*f, isolate));
- }
-
- // Simulate incremental marking so that unoptimized function is enqueued as a
- // candidate for code flushing. The shared function info however will not be
- // explicitly enqueued.
- SimulateIncrementalMarking(heap);
-
- // Now optimize the function so that it is taken off the candidate list.
- {
- HandleScope inner_scope(isolate);
- CompileRun("%OptimizeFunctionOnNextCall(f); f(3);");
- }
-
- // This cycle will bust the heap and subsequent cycles will go ballistic.
- heap->CollectAllGarbage();
- heap->CollectAllGarbage();
-}
-
-
-TEST(Regress173458) {
- if (i::FLAG_never_compact) return;
- i::FLAG_always_compact = true;
- i::FLAG_cache_optimized_code = false;
- i::FLAG_allow_natives_syntax = true;
- CcTest::InitializeVM();
- Isolate* isolate = CcTest::i_isolate();
- Heap* heap = isolate->heap();
- HandleScope scope(isolate);
-
- // Perform one initial GC to enable code flushing.
- heap->CollectAllGarbage();
-
- // Ensure the code ends up on an evacuation candidate.
- SimulateFullSpace(heap->code_space());
-
- // Prepare an unoptimized function that is eligible for code flushing.
- Handle<JSFunction> function;
- {
- HandleScope inner_scope(isolate);
- CompileRun("function mkClosure() {"
- " return function(x) { return x + 1; };"
- "}"
- "var f = mkClosure();"
- "f(1); f(2);");
-
- Handle<JSFunction> f =
- v8::Utils::OpenHandle(
- *v8::Handle<v8::Function>::Cast(
- CcTest::global()->Get(v8_str("f"))));
- CHECK(f->is_compiled());
- const int kAgingThreshold = 6;
- for (int i = 0; i < kAgingThreshold; i++) {
- f->shared()->code()->MakeOlder(static_cast<MarkingParity>(i % 2));
- }
-
- function = inner_scope.CloseAndEscape(handle(*f, isolate));
- }
-
- // Simulate incremental marking so that unoptimized function is enqueued as a
- // candidate for code flushing. The shared function info however will not be
- // explicitly enqueued.
- SimulateIncrementalMarking(heap);
-
- // Now enable the debugger which in turn will disable code flushing.
- CHECK(isolate->debug()->Load());
-
- // This cycle will bust the heap and subsequent cycles will go ballistic.
- heap->CollectAllGarbage();
- heap->CollectAllGarbage();
-}
-
-
#ifdef DEBUG
TEST(Regress513507) {
i::FLAG_flush_optimized_code_cache = false;
« no previous file with comments | « test/cctest/test-compiler.cc ('k') | test/mjsunit/regress/regress-2193.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698