Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1399033002: Remove FLAG_cache_optimized_code because we always have it on. (Closed)

Created:
5 years, 2 months ago by mvstanton
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove FLAG_cache_optimized_code because we always have it on. The data structure that holds the optimized code is becoming essential for additional functionality, too. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/76bee8067253da517a91c513cbeeb69a35f86d65 Cr-Commit-Position: refs/heads/master@{#31216}

Patch Set 1 #

Patch Set 2 : comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -126 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/factory.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M test/mjsunit/regress/regress-2193.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Michi, here is a quick CL to remove the flag we discussed. Thanks, --Michael
5 years, 2 months ago (2015-10-09 14:59:08 UTC) #1
Michael Starzinger
LGTM, we should also remove the flag from the regress-2193.js file.
5 years, 2 months ago (2015-10-12 08:26:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399033002/20001
5 years, 2 months ago (2015-10-12 15:46:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-12 16:10:49 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 16:11:10 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76bee8067253da517a91c513cbeeb69a35f86d65
Cr-Commit-Position: refs/heads/master@{#31216}

Powered by Google App Engine
This is Rietveld 408576698