Issue 139903015: Remove Windows mock theme engine code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139903015: Remove Windows mock theme engine code. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke

Modified:
6 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jochen (gone - plz use gerrit), jamesr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove win mock theme engine code. Now that Aura is required for Windows, we can safely delete the non-Aura mock theme code and simplify the logic for the other cases. R=jam@chromium.org BUG=330735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247799

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+10 lines, -1468 lines)			Patch
content/content_shell.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
content/shell/renderer/test_runner/TestInterfaces.h	View	2 chunks	+6 lines, -10 lines	0 comments	Download
content/shell/renderer/test_runner/TestInterfaces.cpp	View	1 chunk	+4 lines, -11 lines	0 comments	Download
content/shell/renderer/test_runner/WebTestThemeControlWin.h	View	1 chunk	+0 lines, -177 lines	0 comments	Download
content/shell/renderer/test_runner/WebTestThemeControlWin.cpp	View	1 chunk	+0 lines, -465 lines	0 comments	Download
content/shell/renderer/test_runner/WebTestThemeEngineMock.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
content/shell/renderer/test_runner/WebTestThemeEngineWin.h	View	1 chunk	+0 lines, -81 lines	0 comments	Download
content/shell/renderer/test_runner/WebTestThemeEngineWin.cpp	View	1 chunk	+0 lines, -716 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Committed patchset #1 manually as r247799 (presubmit successful).

6 years, 10 months ago (2014-01-30 01:29:28 UTC) #3

Dirk Pranke

6 years, 10 months ago (2014-01-30 01:30:09 UTC) #4

Message was sent while issue was closed.

On 2014/01/30 01:29:28, Dirk Pranke wrote:
> Committed patchset #1 manually as r247799 (presubmit successful).

(try job failures looked like flakes).

Expand Messages | Collapse Messages