List literals in polymer_expressions

pkg/polymer_expressions/lib/eval.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library polymer_expressions.eval;
 
 import 'dart:async';
 import 'dart:collection';
 
 @MirrorsUsed(metaTargets: const [Reflectable, ObservableProperty],
@@ skipping 318 matching lines @@
         ? null
         : i.arguments.map(visit).toList(growable: false);
     var invoke =  new InvokeObserver(i, receiver, args);
     receiver._parent = invoke;
     if (args != null) args.forEach((a) => a._parent = invoke);
     return invoke;
   }
 
   visitLiteral(Literal l) => new LiteralObserver(l);
 
+  visitListLiteral(ListLiteral l) {
+    var items = l.items.map(visit).toList(growable: false);
+    var list = new ListLiteralObserver(l, items);
+    items.forEach((e) => e._parent = list);

[Jennifer Messerly, 2014/01/28 00:07:04]

thought for future refactoring ... it might be more consistent to move the
_parent logic to the constructor for the various types. That way the correct
parent relationship is guaranteed after construction.

I wouldn't do it in this CL though since it would affect all of the visit*
methods :)

[justinfagnani, 2014/01/28 02:16:21]

Agreed. I actually want to get rid of the observer wrappers all together, which
I think would force this to happen.

+    return list;
+  }
+
   visitMapLiteral(MapLiteral l) {
     var entries = l.entries.map(visit).toList(growable: false);
     var map = new MapLiteralObserver(l, entries);
     entries.forEach((e) => e._parent = map);
     return map;
   }
 
   visitMapLiteralEntry(MapLiteralEntry e) {
     var key = visit(e.key);
     var value = visit(e.entryValue);
@@ skipping 62 matching lines @@
 
   dynamic get value => _expr.value;
 
   _updateSelf(Scope scope) {
     _value = _expr.value;
   }
 
   accept(Visitor v) => v.visitLiteral(this);
 }
 
+class ListLiteralObserver extends ExpressionObserver<ListLiteral>
+    implements ListLiteral {
+
+  final List<ExpressionObserver> items;
+
+  ListLiteralObserver(ListLiteral value, this.items) : super(value);
+
+  _updateSelf(Scope scope) {
+    _value = items.map((i) => i._value).toList(growable: false);
+  }
+
+  accept(Visitor v) => v.visitListLiteral(this);
+}
+
 class MapLiteralObserver extends ExpressionObserver<MapLiteral>
     implements MapLiteral {
 
   final List<MapLiteralEntryObserver> entries;
 
   MapLiteralObserver(MapLiteral value, this.entries) : super(value);
 
   _updateSelf(Scope scope) {
     _value = entries.fold(new Map(),
         (m, e) => m..[e.key._value] = e.entryValue._value);
@@ skipping 291 matching lines @@
    * This does not work for calls that need to pass more than one argument.
    */
   call(arg0) => mirror.invoke(symbol, [arg0], null).reflectee;
 }
 
 class EvalException implements Exception {
   final String message;
   EvalException(this.message);
   String toString() => "EvalException: $message";
 }