Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139903006: Remove attach_ as publicly exposed method of Event. (Closed)

Created:
6 years, 11 months ago by Fady Samuel
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove attach_ as publicly exposed method of Event. BUG=324859 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247899

Patch Set 1 #

Patch Set 2 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/renderer/resources/extensions/event.js View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Fady Samuel
It doesn't seem like hiding attach_ breaks tests.
6 years, 10 months ago (2014-01-28 20:48:43 UTC) #1
not at google - send to devlin
your message doesn't instill confidence in me, but lgtm.
6 years, 10 months ago (2014-01-29 00:50:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/139903006/1
6 years, 10 months ago (2014-01-29 02:19:47 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/renderer/resources/extensions/event.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-29 02:19:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/139903006/70001
6 years, 10 months ago (2014-01-29 03:03:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253290
6 years, 10 months ago (2014-01-29 06:39:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/139903006/70001
6 years, 10 months ago (2014-01-29 16:04:40 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 08:39:17 UTC) #8
Message was sent while issue was closed. 
Change committed as 247899

Powered by Google App Engine
This is Rietveld 408576698