src/x64/full-codegen-x64.cc - Issue 139903005: We shouldn't throw under FLAG_debug_code, rather abort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 139903005: We shouldn't throw under FLAG_debug_code, rather abort. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: REBASE + mjsunit.status todo update. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index c4aedd4b684524d1a9f429c4454850d729168cfd..078c6df2042e978be512d0c70c219ba840fa72f8 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -3392,8 +3392,8 @@ void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) {

__ pop(index);

if (FLAG_debug_code) {

- __ ThrowIf(NegateCondition(__ CheckSmi(value)), kNonSmiValue);

- __ ThrowIf(NegateCondition(__ CheckSmi(index)), kNonSmiValue);

+ __ Check(__ CheckSmi(value), kNonSmiValue);

+ __ Check(__ CheckSmi(index), kNonSmiValue);

}

__ SmiToInteger32(value, value);

@@ -3425,8 +3425,8 @@ void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) {