Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 139903005: We shouldn't throw under FLAG_debug_code, rather abort. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE + mjsunit.status todo update. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3440 matching lines...) Expand 10 before | Expand all | Expand 10 after
3451 Register index = r1; 3451 Register index = r1;
3452 Register value = r2; 3452 Register value = r2;
3453 3453
3454 VisitForStackValue(args->at(1)); // index 3454 VisitForStackValue(args->at(1)); // index
3455 VisitForStackValue(args->at(2)); // value 3455 VisitForStackValue(args->at(2)); // value
3456 VisitForAccumulatorValue(args->at(0)); // string 3456 VisitForAccumulatorValue(args->at(0)); // string
3457 __ Pop(index, value); 3457 __ Pop(index, value);
3458 3458
3459 if (FLAG_debug_code) { 3459 if (FLAG_debug_code) {
3460 __ SmiTst(value); 3460 __ SmiTst(value);
3461 __ ThrowIf(ne, kNonSmiValue); 3461 __ Check(eq, kNonSmiValue);
3462 __ SmiTst(index); 3462 __ SmiTst(index);
3463 __ ThrowIf(ne, kNonSmiIndex); 3463 __ Check(eq, kNonSmiIndex);
3464 __ SmiUntag(index, index); 3464 __ SmiUntag(index, index);
3465 static const uint32_t one_byte_seq_type = kSeqStringTag | kOneByteStringTag; 3465 static const uint32_t one_byte_seq_type = kSeqStringTag | kOneByteStringTag;
3466 __ EmitSeqStringSetCharCheck(string, index, value, one_byte_seq_type); 3466 __ EmitSeqStringSetCharCheck(string, index, value, one_byte_seq_type);
3467 __ SmiTag(index, index); 3467 __ SmiTag(index, index);
3468 } 3468 }
3469 3469
3470 __ SmiUntag(value, value); 3470 __ SmiUntag(value, value);
3471 __ add(ip, 3471 __ add(ip,
3472 string, 3472 string,
3473 Operand(SeqOneByteString::kHeaderSize - kHeapObjectTag)); 3473 Operand(SeqOneByteString::kHeaderSize - kHeapObjectTag));
(...skipping 10 matching lines...) Expand all
3484 Register index = r1; 3484 Register index = r1;
3485 Register value = r2; 3485 Register value = r2;
3486 3486
3487 VisitForStackValue(args->at(1)); // index 3487 VisitForStackValue(args->at(1)); // index
3488 VisitForStackValue(args->at(2)); // value 3488 VisitForStackValue(args->at(2)); // value
3489 VisitForAccumulatorValue(args->at(0)); // string 3489 VisitForAccumulatorValue(args->at(0)); // string
3490 __ Pop(index, value); 3490 __ Pop(index, value);
3491 3491
3492 if (FLAG_debug_code) { 3492 if (FLAG_debug_code) {
3493 __ SmiTst(value); 3493 __ SmiTst(value);
3494 __ ThrowIf(ne, kNonSmiValue); 3494 __ Check(eq, kNonSmiValue);
3495 __ SmiTst(index); 3495 __ SmiTst(index);
3496 __ ThrowIf(ne, kNonSmiIndex); 3496 __ Check(eq, kNonSmiIndex);
3497 __ SmiUntag(index, index); 3497 __ SmiUntag(index, index);
3498 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag; 3498 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag;
3499 __ EmitSeqStringSetCharCheck(string, index, value, two_byte_seq_type); 3499 __ EmitSeqStringSetCharCheck(string, index, value, two_byte_seq_type);
3500 __ SmiTag(index, index); 3500 __ SmiTag(index, index);
3501 } 3501 }
3502 3502
3503 __ SmiUntag(value, value); 3503 __ SmiUntag(value, value);
3504 __ add(ip, 3504 __ add(ip,
3505 string, 3505 string,
3506 Operand(SeqTwoByteString::kHeaderSize - kHeapObjectTag)); 3506 Operand(SeqTwoByteString::kHeaderSize - kHeapObjectTag));
(...skipping 1398 matching lines...) Expand 10 before | Expand all | Expand 10 after
4905 ASSERT(Memory::uint32_at(interrupt_address_pointer) == 4905 ASSERT(Memory::uint32_at(interrupt_address_pointer) ==
4906 reinterpret_cast<uint32_t>( 4906 reinterpret_cast<uint32_t>(
4907 isolate->builtins()->OsrAfterStackCheck()->entry())); 4907 isolate->builtins()->OsrAfterStackCheck()->entry()));
4908 return OSR_AFTER_STACK_CHECK; 4908 return OSR_AFTER_STACK_CHECK;
4909 } 4909 }
4910 4910
4911 4911
4912 } } // namespace v8::internal 4912 } } // namespace v8::internal
4913 4913
4914 #endif // V8_TARGET_ARCH_ARM 4914 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698