Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1399003002: Don't include libdisasm.a in libbreakpad.a (Closed)

Created:
5 years, 2 months ago by Jon Turney
Modified:
5 years, 1 month ago
Reviewers:
vapier, Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't include libdisasm.a in libbreakpad.a libbreakpad.a pointlessly contains libdisasm.a This looks like a left-over from when libtool was used Since this has no useful effect (as the linker doesn't recursively search archive members which aren't objects), anything which requires the objects in libdisasm.a must already be linking with it, so simply remove it. BUG=https://code.google.com/p/google-breakpad/issues/detail?id=484 Committed: https://chromium.googlesource.com/breakpad/breakpad/+/27a2e317d75131f52992324ebcdddf97b34c3865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Makefile.am View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jon Turney
5 years, 2 months ago (2015-10-09 14:00:32 UTC) #1
Jon Turney
5 years, 2 months ago (2015-10-12 16:37:31 UTC) #2
Jon Turney
5 years, 2 months ago (2015-10-16 12:54:41 UTC) #4
vapier
Committed patchset #1 (id:1) manually as 27a2e317d75131f52992324ebcdddf97b34c3865 (presubmit successful).
5 years, 1 month ago (2015-11-11 06:17:50 UTC) #5
vapier
5 years, 1 month ago (2015-11-11 06:18:01 UTC) #7
Message was sent while issue was closed.
lgtm

i had to regenerate Makefile.in for you too

Powered by Google App Engine
This is Rietveld 408576698