explicitly initialize all entries in array of SkBaseMatrix, since we can't say

explicitly initialize all entries in array of SkBaseMatrix, since we can't say
that implicitly in C (given that our initializer value may not be all zeros).

crbug.com/174644
Committed: https://code.google.com/p/skia/source/detail?r=8660

[bungeman-skia, 2013-04-11 21:47:06]

Looks like a good idea to me.

https://codereview.chromium.org/13990003/diff/1/trunk/src/core/SkPixelRef.cpp
File trunk/src/core/SkPixelRef.cpp (right):

https://codereview.chromium.org/13990003/diff/1/trunk/src/core/SkPixelRef.cpp...
trunk/src/core/SkPixelRef.cpp:18: { PTHREAD_MUTEX_INITIALIZER }, {
PTHREAD_MUTEX_INITIALIZER },
Since we always want this to be a power of two, would it be cleaner to say
something like 

#define DOUBLE(x) x x
#define ONE { PTHREAD_MUTEX_INITIALIZER },
#define THIRTY_TWO DOUBLE(DOUBLE(DOUBLE(DOUBLE(DOUBLE(ONE)))))

it might make the intent clearer, but isn't necessary.

https://codereview.chromium.org/13990003/diff/1/trunk/src/core/SkPixelRef.cpp...
trunk/src/core/SkPixelRef.cpp:39: // must be a power-of-2. undef to just use 1
mutex
SK_COMPILE_ASSERT the size if a power of 2?

Do the assert outside this ifdef since this always needs to be true.

[reed1, 2013-04-12 14:37:33]

On 2013/04/11 21:47:06, bungeman1 wrote:
> Looks like a good idea to me.
> 
> https://codereview.chromium.org/13990003/diff/1/trunk/src/core/SkPixelRef.cpp
> File trunk/src/core/SkPixelRef.cpp (right):
> 
>
https://codereview.chromium.org/13990003/diff/1/trunk/src/core/SkPixelRef.cpp...
> trunk/src/core/SkPixelRef.cpp:18: { PTHREAD_MUTEX_INITIALIZER }, {
> PTHREAD_MUTEX_INITIALIZER },
> Since we always want this to be a power of two, would it be cleaner to say
> something like 
> 
> #define DOUBLE(x) x x
> #define ONE { PTHREAD_MUTEX_INITIALIZER },
> #define THIRTY_TWO DOUBLE(DOUBLE(DOUBLE(DOUBLE(DOUBLE(ONE)))))
> 
> it might make the intent clearer, but isn't necessary.
> 
>
https://codereview.chromium.org/13990003/diff/1/trunk/src/core/SkPixelRef.cpp...
> trunk/src/core/SkPixelRef.cpp:39: // must be a power-of-2. undef to just use 1
> mutex
> SK_COMPILE_ASSERT the size if a power of 2?
> 
> Do the assert outside this ifdef since this always needs to be true.

Done

[reed1, 2013-04-12 15:34:58]

Committed patchset #2 manually as r8660.