Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 1398973005: ASCIICaseFoldTable should be defined in a .cc file (Closed)

Created:
5 years, 2 months ago by Mikhail
Modified:
5 years, 2 months ago
Reviewers:
tkent, brucedawson
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ASCIICaseFoldTable should be defined in a .cc file In VS 2015 builds of chrome.dll there are 2473 copies of the ASCIICaseFoldTable array, totaling 633088 bytes. BUG=541668 Committed: https://crrev.com/e3e1da9db2a3916d8680772c7d399f208c295474 Cr-Commit-Position: refs/heads/master@{#353922}

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Comments from tkent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -18 lines) Patch
M third_party/WebKit/Source/wtf/ASCIICType.h View 1 chunk +1 line, -18 lines 0 comments Download
A third_party/WebKit/Source/wtf/ASCIICType.cpp View 1 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Mikhail
PTAL
5 years, 2 months ago (2015-10-12 14:18:54 UTC) #4
brucedawson
Perfect. Much better having the definition in the .cc file rather than .h file.
5 years, 2 months ago (2015-10-12 16:49:40 UTC) #6
tkent
https://codereview.chromium.org/1398973005/diff/40001/third_party/WebKit/Source/wtf/ASCIICType.cpp File third_party/WebKit/Source/wtf/ASCIICType.cpp (right): https://codereview.chromium.org/1398973005/diff/40001/third_party/WebKit/Source/wtf/ASCIICType.cpp#newcode1 third_party/WebKit/Source/wtf/ASCIICType.cpp:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
5 years, 2 months ago (2015-10-12 23:09:03 UTC) #7
brucedawson
https://codereview.chromium.org/1398973005/diff/40001/third_party/WebKit/Source/wtf/ASCIICType.cpp File third_party/WebKit/Source/wtf/ASCIICType.cpp (right): https://codereview.chromium.org/1398973005/diff/40001/third_party/WebKit/Source/wtf/ASCIICType.cpp#newcode10 third_party/WebKit/Source/wtf/ASCIICType.cpp:10: WTF_EXPORT const LChar ASCIICaseFoldTable[256] = { On 2015/10/12 23:09:03, ...
5 years, 2 months ago (2015-10-12 23:11:03 UTC) #8
Mikhail
On 2015/10/12 23:11:03, brucedawson wrote: > https://codereview.chromium.org/1398973005/diff/40001/third_party/WebKit/Source/wtf/ASCIICType.cpp > File third_party/WebKit/Source/wtf/ASCIICType.cpp (right): > > https://codereview.chromium.org/1398973005/diff/40001/third_party/WebKit/Source/wtf/ASCIICType.cpp#newcode10 > ...
5 years, 2 months ago (2015-10-13 11:09:35 UTC) #9
tkent
lgtm
5 years, 2 months ago (2015-10-13 23:55:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398973005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398973005/60001
5 years, 2 months ago (2015-10-13 23:57:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-10-14 00:24:00 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e3e1da9db2a3916d8680772c7d399f208c295474 Cr-Commit-Position: refs/heads/master@{#353922}
5 years, 2 months ago (2015-10-14 00:25:02 UTC) #14
tfarina
Just curious, which tool did you use on chrome.dll to discover that it had 2473 ...
5 years, 2 months ago (2015-10-14 00:40:49 UTC) #15
brucedawson
5 years, 2 months ago (2015-10-14 00:59:52 UTC) #16
Message was sent while issue was closed.
On 2015/10/14 00:40:49, tfarina wrote:
> Just curious, which tool did you use on chrome.dll to discover that it had
2473
> copies of ASCIICaseFoldTable? If you could paste the command line that would
be
> cool.
> 
> I think on Linux that could be done using nm (I dunno).

I used a modified version of dia2dump, configured to collect and report on
duplicates and on large globals. dia2dump ships with Visual Studio in source
form:

https://msdn.microsoft.com/en-us/library/b5ke49f5.aspx

Powered by Google App Engine
This is Rietveld 408576698