Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 13989008: MIPS: Accurate function prototypes for native calls from ARM simulator. (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 8 months ago
Reviewers:
kisg, Paul Lind, ulan, kilvadyb, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Accurate function prototypes for native calls from ARM simulator. Port r14230 (76c22097) Original commit message: Native method invocation from the arm/simulator-arm.cc previously made non-portable assumptions about calling conventions. This was okay for 32-bit stack-based machines, where by-value structs are automatically materialized on the stack, and where both int and double parameters could be passed on the stack. However they are not okay for x86-64, which has an elaborate scheme for passing parameters in registers. This CL replaces the previous non-portable code paths with portable code, using call-sites that accurately match the prototype of the callee. BUG=

Patch Set 1 #

Patch Set 2 : Fixed register usage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -73 lines) Patch
M src/mips/simulator-mips.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 4 chunks +69 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
7 years, 8 months ago (2013-04-12 00:04:44 UTC) #1
Paul Lind
lgtm
7 years, 8 months ago (2013-04-12 01:54:05 UTC) #2
Paul Lind
I mistakenly committed patchset #1 as r14239. Sorry, Ákos, can you please upload your change ...
7 years, 8 months ago (2013-04-12 02:18:48 UTC) #3
palfia
7 years, 8 months ago (2013-04-12 07:47:14 UTC) #4
On 2013/04/12 02:18:48, Paul Lind wrote:
> I mistakenly committed patchset #1 as r14239.
> 
> Sorry, Ákos, can you please upload your change in patchset 2 as a separate CL.

Uploaded patchset 2 as a separate CL: https://codereview.chromium.org/14046006/

Powered by Google App Engine
This is Rietveld 408576698