Issue 13989007: [Android] Split uiautomator test runner from instrumentation.

Issue 13989007: [Android] Split uiautomator test runner from instrumentation. (Closed)

Created:
7 years, 8 months ago by frankf

Modified:
7 years, 8 months ago

Reviewers:
craigdh

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Split uiautomator test runner from instrumentation. Also, some minor refactoring. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193967

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -121 lines)			Patch
M	build/android/pylib/android_commands.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/android/pylib/base/base_test_runner.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	build/android/pylib/base/shard.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/android/pylib/host_driven/run_python_tests.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/android/pylib/instrumentation/dispatch.py	View		2 chunks	+7 lines, -53 lines	0 comments	Download
M	build/android/pylib/instrumentation/test_jar.py	View		2 chunks	+60 lines, -9 lines	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View	1	7 chunks	+11 lines, -38 lines	0 comments	Download
A	build/android/pylib/uiautomator/dispatch.py	View		1 chunk	+54 lines, -0 lines	0 comments	Download
A	build/android/pylib/uiautomator/test_runner.py	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
M	build/android/pylib/utils/test_options_parser.py	View		3 chunks	+11 lines, -16 lines	0 comments	Download
M	build/android/run_instrumentation_tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/run_uiautomator_tests.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

craigdh

lgtm. I think it's worth adding an dummy uiautomator test upstream. https://codereview.chromium.org/13989007/diff/1/build/android/pylib/uiautomator/test_runner.py File build/android/pylib/uiautomator/test_runner.py (right): ...

7 years, 8 months ago (2013-04-12 17:32:14 UTC) #1

frankf

https://codereview.chromium.org/13989007/diff/1/build/android/pylib/uiautomator/test_runner.py File build/android/pylib/uiautomator/test_runner.py (right): https://codereview.chromium.org/13989007/diff/1/build/android/pylib/uiautomator/test_runner.py#newcode27 build/android/pylib/uiautomator/test_runner.py:27: #override. On 2013/04/12 17:32:14, craigdh wrote: > no . ...

7 years, 8 months ago (2013-04-12 18:00:13 UTC) #2

frankf

7 years, 8 months ago (2013-04-12 18:30:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r193967 (presubmit successful).

Expand Messages | Collapse Messages