Replace MediaStreamUIController with MediaStreamUIProxy.

Replace MediaStreamUIController with MediaStreamUIProxy.

Previously a single object MediaStreamUIController was used to control UI for 
all streams. Replaced it with a per-stream MediaStreamUIProxy that simplifies
code in many places.
Also moved media request queueing logic from content layer to chrome. Now 
different types of requests may be queued differently (e.g. there is no 
reason to block screen capture requests on webcam infobar).

TBR=tommi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197222

[Sergey Ulanov, 2013-04-17 01:27:09]

More cleanups in the media-stream access request code.

[tommi (sloooow) - chröme, 2013-04-22 13:22:39]

looks great. A couple of nits and one request below.

https://codereview.chromium.org/13989003/diff/2001/chrome/browser/media/media...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/13989003/diff/2001/chrome/browser/media/media...
chrome/browser/media/media_capture_devices_dispatcher.cc:288: RequestsQueue&
queue(pending_requests_[web_contents]);
nit: since this is a reference use assignment. As is it looks like you're
constructing a new object until one notices the little ampersand in there.

https://codereview.chromium.org/13989003/diff/2001/content/browser/renderer_h...
File content/browser/renderer_host/media/media_stream_ui_proxy.h (right):

https://codereview.chromium.org/13989003/diff/2001/content/browser/renderer_h...
content/browser/renderer_host/media/media_stream_ui_proxy.h:24: explicit
MediaStreamUIProxy();
remove explicit

https://codereview.chromium.org/13989003/diff/2001/content/browser/speech/spe...
File content/browser/speech/speech_recognition_manager_impl.h (right):

https://codereview.chromium.org/13989003/diff/2001/content/browser/speech/spe...
content/browser/speech/speech_recognition_manager_impl.h:169: typedef
std::map<int, Session*> SessionsTable;
can we use scoped_ptr<> and Pass() to protect against leaks?

[Sergey Ulanov, 2013-04-23 05:21:44]

https://codereview.chromium.org/13989003/diff/2001/chrome/browser/media/media...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/13989003/diff/2001/chrome/browser/media/media...
chrome/browser/media/media_capture_devices_dispatcher.cc:288: RequestsQueue&
queue(pending_requests_[web_contents]);
On 2013/04/22 13:22:39, tommi wrote:
> nit: since this is a reference use assignment. As is it looks like you're
> constructing a new object until one notices the little ampersand in there.

Done.

https://codereview.chromium.org/13989003/diff/2001/content/browser/renderer_h...
File content/browser/renderer_host/media/media_stream_ui_proxy.h (right):

https://codereview.chromium.org/13989003/diff/2001/content/browser/renderer_h...
content/browser/renderer_host/media/media_stream_ui_proxy.h:24: explicit
MediaStreamUIProxy();
On 2013/04/22 13:22:39, tommi wrote:
> remove explicit

Done.

https://codereview.chromium.org/13989003/diff/2001/content/browser/speech/spe...
File content/browser/speech/speech_recognition_manager_impl.h (right):

https://codereview.chromium.org/13989003/diff/2001/content/browser/speech/spe...
content/browser/speech/speech_recognition_manager_impl.h:169: typedef
std::map<int, Session*> SessionsTable;
On 2013/04/22 13:22:39, tommi wrote:
> can we use scoped_ptr<> and Pass() to protect against leaks?

No. STL collections work only with copyable types, and scoped_ptr<> isn't
copyable (in other words stl::map doesn't know that it must call Pass()).
Hopefully this will be improved once we switch to C++11.

[tommi (sloooow) - chröme, 2013-04-23 11:20:47]

lgtm

https://codereview.chromium.org/13989003/diff/24001/chrome/browser/media/medi...
File chrome/browser/media/media_capture_devices_dispatcher.h (right):

https://codereview.chromium.org/13989003/diff/24001/chrome/browser/media/medi...
chrome/browser/media/media_capture_devices_dispatcher.h:120:
PendingAccessRequest(content::MediaStreamRequest request,
const &

https://codereview.chromium.org/13989003/diff/24001/chrome/browser/media/medi...
chrome/browser/media/media_capture_devices_dispatcher.h:121:
content::MediaResponseCallback callback);
const &

[Sergey Ulanov, 2013-04-29 18:17:56]

https://codereview.chromium.org/13989003/diff/24001/chrome/browser/media/medi...
File chrome/browser/media/media_capture_devices_dispatcher.h (right):

https://codereview.chromium.org/13989003/diff/24001/chrome/browser/media/medi...
chrome/browser/media/media_capture_devices_dispatcher.h:120:
PendingAccessRequest(content::MediaStreamRequest request,
On 2013/04/23 11:20:47, tommi wrote:
> const &

Done.

https://codereview.chromium.org/13989003/diff/24001/chrome/browser/media/medi...
chrome/browser/media/media_capture_devices_dispatcher.h:121:
content::MediaResponseCallback callback);
On 2013/04/23 11:20:47, tommi wrote:
> const &

Done.

[commit-bot: I haz the power, 2013-04-29 18:23:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/13989003/30010

[commit-bot: I haz the power, 2013-04-29 21:49:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/13989003/44001

[commit-bot: I haz the power, 2013-04-29 21:57:33]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Sergey Ulanov, 2013-04-30 01:47:39]

On 2013/04/29 21:57:33, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

+avi@chromium.org in TBR for trivial in gypi files

[Sergey Ulanov, 2013-04-30 01:53:37]

Committed patchset #5 manually as r197222 (presubmit successful).