Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1398873002: remove "infer from overrides" option which is now obsolete (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly
Modified:
5 years, 2 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove "infer from overrides" option which is now obsolete R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/f335640ddbce7f0342253bfeb1440a999a8e11bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -174 lines) Patch
M lib/src/checker/checker.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M lib/src/checker/resolver.dart View 1 chunk +11 lines, -17 lines 0 comments Download
M lib/src/compiler.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M lib/strong_mode.dart View 6 chunks +2 lines, -14 lines 0 comments Download
M test/checker/checker_test.dart View 6 chunks +12 lines, -24 lines 0 comments Download
M test/checker/inferred_type_test.dart View 19 chunks +55 lines, -104 lines 0 comments Download
M test/testing.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
I'm doing some housecleaning to make it easier to move this code to Analyzer. Going ...
5 years, 2 months ago (2015-10-08 21:23:14 UTC) #2
Jennifer Messerly
On 2015/10/08 21:23:14, John Messerly wrote: > I'm doing some housecleaning to make it easier ...
5 years, 2 months ago (2015-10-08 21:23:35 UTC) #3
vsm
lgtm!
5 years, 2 months ago (2015-10-09 14:54:30 UTC) #4
Jennifer Messerly
5 years, 2 months ago (2015-10-09 17:56:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f335640ddbce7f0342253bfeb1440a999a8e11bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698