Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1398843008: Fix Enum.toString when enum type is private. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/enum_test.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 2 months ago (2015-10-15 17:51:29 UTC) #2
hausner
LGTM.
5 years, 2 months ago (2015-10-15 18:09:57 UTC) #3
rmacnak
5 years, 2 months ago (2015-10-15 18:28:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b56991878f8afa3078c74badf4192e7ca2da1242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698