|
|
Created:
6 years, 11 months ago by fmeawad Modified:
6 years, 11 months ago Reviewers:
martone, tonyg CC:
chromium-reviews, chrome-speed-team+watch_google.com Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionKey search on mobile page set
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245265
Patch Set 1 #
Total comments: 4
Patch Set 2 : Rename to key_search_mobile and add few more queries #Patch Set 3 : Add more searches #Patch Set 4 : Refine the search term set #
Total comments: 3
Patch Set 5 : Make 50% of the searches use https #Messages
Total messages: 11 (0 generated)
I have created the page set, not sure if I should upload the recording as well. PTAL
https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_sea... File tools/perf/page_sets/top_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_sea... tools/perf/page_sets/top_search_mobile.json:2: "description": "Top mobile search queries on google", Let's call this key_search_mobile instead of top_search_mobile. Page sets with top in the name imply popularity. Those with key in the name imply that they are interesting examples. https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_sea... tools/perf/page_sets/top_search_mobile.json:39: } Let's get some other interesting widgets: Movies: q=tom+hanks Weather: q=weather Finance: q=goog Andy might have additional ideas of public widgets that would be nice to include in this page set. (or at least know of someone who would know)
https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_sea... File tools/perf/page_sets/top_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_sea... tools/perf/page_sets/top_search_mobile.json:2: "description": "Top mobile search queries on google", On 2014/01/15 23:50:46, tonyg wrote: > Let's call this key_search_mobile instead of top_search_mobile. Page sets with > top in the name imply popularity. Those with key in the name imply that they are > interesting examples. Done. https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_sea... tools/perf/page_sets/top_search_mobile.json:39: } On 2014/01/15 23:50:46, tonyg wrote: > Let's get some other interesting widgets: > Movies: q=tom+hanks > Weather: q=weather > Finance: q=goog > > Andy might have additional ideas of public widgets that would be nice to include > in this page set. (or at least know of someone who would know) Done, waiting on Andy's feedback.
Here are some I can think of off the top of my head. Let me know if you'd like more: Charts: q=population+of+california Flights: q=sfo+jfk+flights Movie Showtimes: q=movies+94110 Tip Calculator: q=tip+on+100+bill Sports: q=nfl+schedule (this might go away after the Super Bowl) Time: q=time+in+san+francisco Definitions: q=define+define Local results: q=burritos+94110 Graph: q=x^2 3D Graph: q=sqrt%28x*x%2By*y%29%2B3*cos%28sqrt%28x*x%2By*y%29%29%2B5+from+-20+to+20 On Wed, Jan 15, 2014 at 4:10 PM, <fmeawad@chromium.org> wrote: > > https://codereview.chromium.org/139883003/diff/1/tools/ > perf/page_sets/top_search_mobile.json > File tools/perf/page_sets/top_search_mobile.json (right): > > https://codereview.chromium.org/139883003/diff/1/tools/ > perf/page_sets/top_search_mobile.json#newcode2 > tools/perf/page_sets/top_search_mobile.json:2: "description": "Top > mobile search queries on google", > On 2014/01/15 23:50:46, tonyg wrote: > >> Let's call this key_search_mobile instead of top_search_mobile. Page >> > sets with > >> top in the name imply popularity. Those with key in the name imply >> > that they are > >> interesting examples. >> > > Done. > > https://codereview.chromium.org/139883003/diff/1/tools/ > perf/page_sets/top_search_mobile.json#newcode39 > tools/perf/page_sets/top_search_mobile.json:39: } > > On 2014/01/15 23:50:46, tonyg wrote: > >> Let's get some other interesting widgets: >> Movies: q=tom+hanks >> Weather: q=weather >> Finance: q=goog >> > > Andy might have additional ideas of public widgets that would be nice >> > to include > >> in this page set. (or at least know of someone who would know) >> > > > Done, waiting on Andy's feedback. > > https://codereview.chromium.org/139883003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2014/01/16 01:03:34, martone_google.com wrote: > Here are some I can think of off the top of my head. Let me know if you'd > like more: > > Charts: q=population+of+california > Flights: q=sfo+jfk+flights > Movie Showtimes: q=movies+94110 > Tip Calculator: q=tip+on+100+bill > Sports: q=nfl+schedule (this might go away after the Super Bowl) > Time: q=time+in+san+francisco > Definitions: q=define+define > Local results: q=burritos+94110 > Graph: q=x^2 > 3D > Graph: > q=sqrt%28x*x%2By*y%29%2B3*cos%28sqrt%28x*x%2By*y%29%29%2B5+from+-20+to+20 Thanks! Exactly what we were looking for. Fadi, I'd recommend just picking the most interesting/diverse set and holding it to no more than 10-15 pages. lgtm whenever you are ready to land.
On 2014/01/16 01:09:31, tonyg wrote: > On 2014/01/16 01:03:34, http://martone_google.com wrote: > > Here are some I can think of off the top of my head. Let me know if you'd > > like more: > > > > Charts: q=population+of+california > > Flights: q=sfo+jfk+flights > > Movie Showtimes: q=movies+94110 > > Tip Calculator: q=tip+on+100+bill > > Sports: q=nfl+schedule (this might go away after the Super Bowl) > > Time: q=time+in+san+francisco > > Definitions: q=define+define > > Local results: q=burritos+94110 > > Graph: q=x^2 > > 3D > > Graph: > > q=sqrt%28x*x%2By*y%29%2B3*cos%28sqrt%28x*x%2By*y%29%29%2B5+from+-20+to+20 > > Thanks! Exactly what we were looking for. > > Fadi, I'd recommend just picking the most interesting/diverse set and holding it > to no more than 10-15 pages. > > lgtm whenever you are ready to land. I removed calculator for tip starbucks for burrito 3D graph not showing on mobile sometimes. List currently at 15. PTAL.
https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/ke... File tools/perf/page_sets/key_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/ke... tools/perf/page_sets/key_search_mobile.json:65: "url": "http://www.google.com/search?q=x^3", x^2 shows also a movie at the top before the graph.
lgtm https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/ke... File tools/perf/page_sets/key_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/ke... tools/perf/page_sets/key_search_mobile.json:9: "url": "http://www.google.com/", One more note, when I search from the omnibox is chrome on android it takes me to the https URL instead of HTTP. We should probably make this list about 50% https and 50% http.
https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/ke... File tools/perf/page_sets/key_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/ke... tools/perf/page_sets/key_search_mobile.json:9: "url": "http://www.google.com/", On 2014/01/16 01:41:34, tonyg wrote: > One more note, when I search from the omnibox is chrome on android it takes me > to the https URL instead of HTTP. We should probably make this list about 50% > https and 50% http. Done.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/139883003/200001
Message was sent while issue was closed.
Change committed as 245265 |