Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 139883003: Key search on mobile page set (Closed)

Created:
6 years, 11 months ago by fmeawad
Modified:
6 years, 11 months ago
Reviewers:
martone, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Key search on mobile page set BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245265

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename to key_search_mobile and add few more queries #

Patch Set 3 : Add more searches #

Patch Set 4 : Refine the search term set #

Total comments: 3

Patch Set 5 : Make 50% of the searches use https #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
A tools/perf/page_sets/key_search_mobile.json View 1 2 3 4 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
fmeawad
I have created the page set, not sure if I should upload the recording as ...
6 years, 11 months ago (2014-01-15 23:17:07 UTC) #1
tonyg
https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_search_mobile.json File tools/perf/page_sets/top_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_search_mobile.json#newcode2 tools/perf/page_sets/top_search_mobile.json:2: "description": "Top mobile search queries on google", Let's call ...
6 years, 11 months ago (2014-01-15 23:50:45 UTC) #2
fmeawad
https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_search_mobile.json File tools/perf/page_sets/top_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/1/tools/perf/page_sets/top_search_mobile.json#newcode2 tools/perf/page_sets/top_search_mobile.json:2: "description": "Top mobile search queries on google", On 2014/01/15 ...
6 years, 11 months ago (2014-01-16 00:10:48 UTC) #3
martone_google.com
Here are some I can think of off the top of my head. Let me ...
6 years, 11 months ago (2014-01-16 01:03:34 UTC) #4
tonyg
On 2014/01/16 01:03:34, martone_google.com wrote: > Here are some I can think of off the ...
6 years, 11 months ago (2014-01-16 01:09:31 UTC) #5
fmeawad
On 2014/01/16 01:09:31, tonyg wrote: > On 2014/01/16 01:03:34, http://martone_google.com wrote: > > Here are ...
6 years, 11 months ago (2014-01-16 01:28:20 UTC) #6
fmeawad
https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/key_search_mobile.json File tools/perf/page_sets/key_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/key_search_mobile.json#newcode65 tools/perf/page_sets/key_search_mobile.json:65: "url": "http://www.google.com/search?q=x^3", x^2 shows also a movie at the ...
6 years, 11 months ago (2014-01-16 01:29:04 UTC) #7
tonyg
lgtm https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/key_search_mobile.json File tools/perf/page_sets/key_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/key_search_mobile.json#newcode9 tools/perf/page_sets/key_search_mobile.json:9: "url": "http://www.google.com/", One more note, when I search ...
6 years, 11 months ago (2014-01-16 01:41:34 UTC) #8
fmeawad
https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/key_search_mobile.json File tools/perf/page_sets/key_search_mobile.json (right): https://codereview.chromium.org/139883003/diff/130001/tools/perf/page_sets/key_search_mobile.json#newcode9 tools/perf/page_sets/key_search_mobile.json:9: "url": "http://www.google.com/", On 2014/01/16 01:41:34, tonyg wrote: > One ...
6 years, 11 months ago (2014-01-16 01:51:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/139883003/200001
6 years, 11 months ago (2014-01-16 02:14:15 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 18:35:39 UTC) #11
Message was sent while issue was closed.
Change committed as 245265

Powered by Google App Engine
This is Rietveld 408576698