chrome/renderer/chrome_render_frame_observer.h - Issue 1398823004: Switch the page-capturing machinery to use the new hooks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_frame_observer.h

Issue 1398823004: Switch the page-capturing machinery to use the new hooks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes http://crbug.com/583261. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc ('k') | chrome/renderer/chrome_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_render_frame_observer.h

diff --git a/chrome/renderer/chrome_render_frame_observer.h b/chrome/renderer/chrome_render_frame_observer.h

index d745491092e5b7cddc60910e18efc58ea6820a31..c3408e47c61bbf4a5a1199d7983a20604b3ba472 100644

--- a/chrome/renderer/chrome_render_frame_observer.h

+++ b/chrome/renderer/chrome_render_frame_observer.h

@@ -40,6 +40,7 @@ class ChromeRenderFrameObserver : public content::RenderFrameObserver {

void DidFinishLoad() override;

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;

+ void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;

// IPC handlers

void OnSetIsPrerendering(bool is_prerendering);

@@ -63,9 +64,6 @@ class ChromeRenderFrameObserver : public content::RenderFrameObserver {

void CapturePageTextLater(TextCaptureType capture_type,

base::TimeDelta delay);

- // Used to delay calling CapturePageInfo.

- base::Timer capture_timer_;

// Have the same lifetime as us.

translate::TranslateHelper* translate_helper_;

safe_browsing::PhishingClassifierDelegate* phishing_classifier_;