Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398823002: We can now name the current VM using the service protocol. (Closed)

Created:
5 years, 2 months ago by turnidge
Modified:
5 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org, danrubel, devoncarew, nweiz
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

We can now name the current VM using the service protocol. Adds a 'VM' stream and a 'VMUpdate' event. Makes Event.isolate optional in service.md. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/435bcdbe6ce95ea02845462fd9fd564713fdd7a7

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Patch Set 3 : more stuff #

Patch Set 4 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -53 lines) Patch
M runtime/observatory/lib/src/app/application.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 3 9 chunks +83 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 11 chunks +36 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/get_vm_rpc_test.dart View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
A runtime/observatory/tests/service/set_vm_name_rpc_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.h View 4 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 3 chunks +13 lines, -1 line 0 comments Download
M runtime/vm/service.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 9 chunks +57 lines, -10 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 6 chunks +30 lines, -9 lines 0 comments Download
M runtime/vm/service_event.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/service_event.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
turnidge
5 years, 2 months ago (2015-10-08 19:53:24 UTC) #2
turnidge
(cc'ing Dan, Devon, Natalie)
5 years, 2 months ago (2015-10-08 19:54:18 UTC) #3
Cutch
LGTM with one issue and a note for a future change. https://codereview.chromium.org/1398823002/diff/1/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): ...
5 years, 2 months ago (2015-10-08 20:05:27 UTC) #4
turnidge
https://codereview.chromium.org/1398823002/diff/1/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/1398823002/diff/1/runtime/observatory/lib/src/service/object.dart#newcode1367 runtime/observatory/lib/src/service/object.dart:1367: vmName = map.containsKey('_vmName') ? map['_vmName'] : name; On 2015/10/08 ...
5 years, 2 months ago (2015-10-08 22:15:26 UTC) #5
turnidge
5 years, 2 months ago (2015-10-08 22:37:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
435bcdbe6ce95ea02845462fd9fd564713fdd7a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698