Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1398803002: Fix DAS, use all the Analyzer plugins. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index b10967a6861048252ca8c16bfa8441400a3903e5..a980fede33247d41b3761e1f7facac66b271a835 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -472,9 +472,8 @@ class ContextManagerImpl implements ContextManager {
}
// Notify options processors.
- AnalysisEngine.instance.optionsPlugin.optionsProcessors
- .forEach(
- (OptionsProcessor p) => p.optionsProcessed(options, info.context));
+ AnalysisEngine.instance.optionsPlugin.optionsProcessors.forEach(
+ (OptionsProcessor p) => p.optionsProcessed(info.context, options));
// Analysis options are processed 'in-line'.
// TODO(pq): consider pushing exclude handling into a plugin.
@@ -825,7 +824,7 @@ class ContextManagerImpl implements ContextManager {
Map<String, YamlNode> options =
analysisOptionsProvider.getOptions(folder);
processOptionsForContext(info, options);
- } on Exception catch (e) {
+ } catch (e) {
// TODO(pquitslund): contribute plugin that sends error notification on options file.
// Related test: context_manager_test.test_analysis_options_parse_failure()
// AnalysisEngine.instance.optionsPlugin.optionsProcessors
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/server/driver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698