Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1398763002: [turbofan] Fix scheduler test for Loop/Terminate nodes. (Closed)

Created:
5 years, 2 months ago by Jarin
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix scheduler test for Loop/Terminate nodes. The test had an effect phi with one effect input connected to a loop with two control inputs. Also, the Terminate node was used by the effect phi. Committed: https://crrev.com/4f64af2fa6fea0035ea0cea1f560478c257399e6 Cr-Commit-Position: refs/heads/master@{#31193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jarin
Could you take a look, please?
5 years, 2 months ago (2015-10-08 15:10:44 UTC) #2
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-10-08 15:40:11 UTC) #3
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-08 16:50:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398763002/1
5 years, 2 months ago (2015-10-09 10:51:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 10:52:50 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 10:53:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f64af2fa6fea0035ea0cea1f560478c257399e6
Cr-Commit-Position: refs/heads/master@{#31193}

Powered by Google App Engine
This is Rietveld 408576698