fpdfsdk/src/javascript/JS_GlobalData.cpp - Issue 1398703009: Next round of XFA changes to match master

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_GlobalData.cpp

Issue 1398703009: Next round of XFA changes to match master (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_GlobalData.cpp

diff --git a/fpdfsdk/src/javascript/JS_GlobalData.cpp b/fpdfsdk/src/javascript/JS_GlobalData.cpp

index e13b50f5ef025285032eb0827b534d1b55db43dd..cf51f9f73d553a52aa1ff816213e12b593331f3a 100644

--- a/fpdfsdk/src/javascript/JS_GlobalData.cpp

+++ b/fpdfsdk/src/javascript/JS_GlobalData.cpp

@@ -117,8 +117,7 @@ void CJS_GlobalData::Release() {

}

-CJS_GlobalData::CJS_GlobalData(CPDFDoc_Environment* pApp)

- : m_pApp(pApp), m_RefCount(0) {

+CJS_GlobalData::CJS_GlobalData(CPDFDoc_Environment* pApp) : m_RefCount(0) {

Lei Zhang 2015/10/14 21:02:27 Why bother even passing in |pApp| then?

m_sFilePath += SDK_JS_GLOBALDATA_FILENAME;

LoadGlobalPersistentVariables();

}