Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1398703007: When converting an mjsunit exception to a string, include the stack (Closed)

Created:
5 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

When converting an mjsunit exception to a string, include the stack Makes debugging failures a bit easier BUG=none R=ulan@chromium.org LOG=n Committed: https://crrev.com/2e8181acd535f8da6bd14e56f8ded9ef26171e2c Cr-Commit-Position: refs/heads/master@{#31195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/mjsunit.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 2 months ago (2015-10-09 11:57:18 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 2 months ago (2015-10-09 13:06:02 UTC) #2
ulan
lgtm
5 years, 2 months ago (2015-10-09 13:10:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398703007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398703007/1
5 years, 2 months ago (2015-10-09 13:10:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 13:11:57 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 13:12:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e8181acd535f8da6bd14e56f8ded9ef26171e2c
Cr-Commit-Position: refs/heads/master@{#31195}

Powered by Google App Engine
This is Rietveld 408576698