Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1398643002: Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:40001 of https://codereview.chromium.org/1383053005/ ) Reason for revert: Breaks Arm debug. Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/93ae81101af68d81b7af84ea4046ea849e605116 > Cr-Commit-Position: refs/heads/master@{#31163} TBR=jochen@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9752a5983ed2fbcb5fbcf03b776e0782539c54f9 Cr-Commit-Position: refs/heads/master@{#31167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -35 lines) Patch
M include/v8config.h View 6 chunks +0 lines, -17 lines 0 comments Download
M src/arguments.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/base/logging.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/base/platform/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-atomicops.cc View 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 ...
5 years, 2 months ago (2015-10-08 04:32:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398643002/1
5 years, 2 months ago (2015-10-08 04:33:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 04:33:30 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 04:33:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9752a5983ed2fbcb5fbcf03b776e0782539c54f9
Cr-Commit-Position: refs/heads/master@{#31167}

Powered by Google App Engine
This is Rietveld 408576698