Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1398633008: Return result of GetRBG instead of TRUE (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Return result of GetRBG instead of TRUE Propagate the return value of GetRBG to the callers instead of forcing the return of TRUE. BUG=pdfium:44 R=thestig@chromium.org, tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b456ba7f62fa416f456ef78750c18fd2bdf837be

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 5 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dsinclair
PTAL. The pdfium_unittests pass with this change, are there other tests/bots I should run?
5 years, 2 months ago (2015-10-15 01:44:48 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-15 02:47:08 UTC) #3
Tom Sepez
> The pdfium_unittests pass with this change, are there other tests/bots I should > run? ...
5 years, 2 months ago (2015-10-15 16:43:53 UTC) #4
dsinclair
5 years, 2 months ago (2015-10-15 23:25:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b456ba7f62fa416f456ef78750c18fd2bdf837be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698