Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 139853011: [Cleanup] Removing changes associated with visualWordMovement since it is never used. (Closed)

Created:
6 years, 11 months ago by Sunil Ratnu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing changes associated with visualWordMovement since this setting is never used in the code. Since the setting visualWordMovement is not used in the code,so removing all the changes associated with it. visualWordMovementEnabled() method is not called anywhere. The other blink changes dependent on this patch can be found here: https://codereview.chromium.org/137583010/ BUG=355009 TBR=cevans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Sunil Ratnu
Please have a look.
6 years, 11 months ago (2014-01-23 14:56:24 UTC) #1
Sunil Ratnu
On 2014/01/23 14:56:24, sunil.ratnu wrote: > Please have a look. ping! Please have a look
6 years, 10 months ago (2014-02-05 05:43:01 UTC) #2
Sunil Ratnu
On 2014/02/05 05:43:01, sunil.ratnu wrote: > On 2014/01/23 14:56:24, sunil.ratnu wrote: > > Please have ...
6 years, 9 months ago (2014-03-05 19:31:01 UTC) #3
jamesr
I'm not familiar with this code or the history. I'm also not an OWNER for ...
6 years, 9 months ago (2014-03-05 20:36:22 UTC) #4
Sunil Ratnu
On 2014/03/05 20:36:22, jamesr (out of office) wrote: > I'm not familiar with this code ...
6 years, 8 months ago (2014-04-16 06:30:05 UTC) #5
jam
lgtm
6 years, 8 months ago (2014-04-16 16:15:24 UTC) #6
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-18 05:32:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/139853011/1
6 years, 8 months ago (2014-04-18 05:32:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 06:27:52 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=62198
6 years, 8 months ago (2014-04-18 06:27:52 UTC) #10
Sunil Ratnu
On 2014/04/18 06:27:52, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 8 months ago (2014-04-18 06:31:34 UTC) #11
darin (slow to review)
change to webkit/ LGTM
6 years, 8 months ago (2014-04-21 16:14:58 UTC) #12
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-22 14:19:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/139853011/1
6 years, 8 months ago (2014-04-22 14:19:29 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 17:14:32 UTC) #15
Message was sent while issue was closed.
Change committed as 265291

Powered by Google App Engine
This is Rietveld 408576698