third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp - Issue 1398523004: Revalidate using the same Resource, attempt #3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

Issue 1398523004: Revalidate using the same Resource, attempt #3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

index 7c178f92e957a916aaaa2bc39b0934728b41cad6..d0a7377c7165306304501d364b4398fda368ff7d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

@@ -650,7 +650,7 @@ bool ScriptStreamer::startStreamingInternal(PendingScript& script, PendingScript

Platform::current()->histogramEnumeration(notStreamingReasonHistogramName(scriptType), NotHTTP, NotStreamingReasonEnd);

return false;

}

- if (resource->resourceToRevalidate()) {

+ if (resource->isCacheValidator()) {

Platform::current()->histogramEnumeration(notStreamingReasonHistogramName(scriptType), Reload, NotStreamingReasonEnd);

// This happens e.g., during reloads. We're actually not going to load

// the current Resource of the PendingScript but switch to another

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp » ('j') | no next file with comments »