Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: net/third_party/nss/patches/norc4falsestart.patch

Issue 13985023: net: don't do TLS False Start with RC4. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address rsleevi's comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/third_party/nss/patches/norc4falsestart.patch
diff --git a/net/third_party/nss/patches/norc4falsestart.patch b/net/third_party/nss/patches/norc4falsestart.patch
new file mode 100644
index 0000000000000000000000000000000000000000..e07726ef75a858d78269aa9f8b16faf542238818
--- /dev/null
+++ b/net/third_party/nss/patches/norc4falsestart.patch
@@ -0,0 +1,24 @@
+diff --git a/net/third_party/nss/ssl/ssl3con.c b/net/third_party/nss/ssl/ssl3con.c
+index ee96089..abc1db0 100644
+--- a/net/third_party/nss/ssl/ssl3con.c
++++ b/net/third_party/nss/ssl/ssl3con.c
+@@ -6411,12 +6411,17 @@ ssl3_CanFalseStart(sslSocket *ss) {
+ * do False Start in the case that the selected ciphersuite is
+ * sufficiently strong that the attack can gain no advantage.
+ * Therefore we require an 80-bit cipher and a forward-secret key
+- * exchange. */
++ * exchange.
++ *
++ * Although RC4 has more than 80 bits of key, biases in the RC4
++ * keystream make its effective security level significantly less.
++ * Because of this, RC4 is not suitable for False Start. */
+ ss->ssl3.cwSpec->cipher_def->secret_key_size >= 10 &&
+ (ss->ssl3.hs.kea_def->kea == kea_dhe_dss ||
+ ss->ssl3.hs.kea_def->kea == kea_dhe_rsa ||
+ ss->ssl3.hs.kea_def->kea == kea_ecdhe_ecdsa ||
+- ss->ssl3.hs.kea_def->kea == kea_ecdhe_rsa);
++ ss->ssl3.hs.kea_def->kea == kea_ecdhe_rsa) &&
++ ss->ssl3.cwSpec->cipher_def->cipher != cipher_rc4;
+ ssl_ReleaseSpecReadLock(ss);
+ return rv;
+ }

Powered by Google App Engine
This is Rietveld 408576698