Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 13985011: Switch generator builtins into strict mode. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 8 months ago
Reviewers:
wingo, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Switch generator builtins into strict mode. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/generator.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 8 months ago (2013-04-12 13:57:33 UTC) #1
wingo
To me it seems OK. (Careful phrasing to avoid a claim to review-power.)
7 years, 8 months ago (2013-04-12 14:06:36 UTC) #2
rossberg
lgtm
7 years, 8 months ago (2013-04-12 15:40:52 UTC) #3
Michael Starzinger
7 years, 8 months ago (2013-04-12 15:52:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r14255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698