Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 13985009: Remove proxy-related environment variables when running standalone tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 8d0de275e2f38dafee253fa16c91949f6f48a909..a168dd7138896fc88a4d6bf5395c16db4f1204f6 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -33,6 +33,10 @@ typedef void TestCaseEvent(TestCase testCase);
typedef void ExitCodeEvent(int exitCode);
typedef void EnqueueMoreWork(ProcessQueue queue);
+const List<String> EXCLUDED_ENVIRONMENT_VARIABLES =
ricow1 2013/04/12 14:39:09 Please add a statement here as to why we do this
+ const ['http_proxy', 'https_proxy', 'no_proxy',
+ 'HTTP_PROXY', 'HTTPS_PROXY', 'NO_PROXY'];
+
/**
* [areByteArraysEqual] compares a range of bytes from [buffer1] with a
@@ -1022,6 +1026,11 @@ class RunningProcess {
options.environment = new Map<String, String>.from(baseEnvironment);
options.environment['DART_CONFIGURATION'] =
TestUtils.configurationDir(testCase.configuration);
+
+ for (var excludedEnvironmentVariable in EXCLUDED_ENVIRONMENT_VARIABLES) {
+ options.environment.remove(excludedEnvironmentVariable);
+ }
+
return options;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698