Separate calculation of double element and object element sizes in IsFastLiteral.

Separate calculation of double element and object element sizes in IsFastLiteral.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14241

[danno, 2013-04-12 08:15:38]

lgtm with comments

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.cc#newcode10111
src/hydrogen.cc:10111: AddInstruction(new(zone) HConstant(doubles_size +
objects_size,
Perhaps put the sum into a "total_size" temp?

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.h#newcode1511
src/hydrogen.h:1511: int doubles_size,
how about using "data_space_size" and "pointer_space_size" for these?

[Hannes Payer (out of office), 2013-04-12 08:38:12]

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.cc#newcode10111
src/hydrogen.cc:10111: AddInstruction(new(zone) HConstant(doubles_size +
objects_size,
On 2013/04/12 08:15:38, danno wrote:
> Perhaps put the sum into a "total_size" temp?

Done.

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/13985005/diff/1/src/hydrogen.h#newcode1511
src/hydrogen.h:1511: int doubles_size,
On 2013/04/12 08:15:38, danno wrote:
> how about using "data_space_size" and "pointer_space_size" for these?

I renamed it to "data_size" and "pointer_size".

[Hannes Payer (out of office), 2013-04-12 08:42:26]

Committed patchset #2 manually as r14241 (presubmit successful).