Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: content/browser/loader/cross_site_resource_handler_browsertest.cc

Issue 1398473002: Revert the fix for 538784. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_isolate_apps3_fix_unittest
Patch Set: Change upstream. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/cross_site_resource_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/cross_site_resource_handler_browsertest.cc
diff --git a/content/browser/loader/cross_site_resource_handler_browsertest.cc b/content/browser/loader/cross_site_resource_handler_browsertest.cc
index 4d66c1a9812275603c130aec7420c5b0d091de3a..ba0f3cc307e6e65ac6a61cf8a5964c7565dc03e0 100644
--- a/content/browser/loader/cross_site_resource_handler_browsertest.cc
+++ b/content/browser/loader/cross_site_resource_handler_browsertest.cc
@@ -239,8 +239,10 @@ void SimulateMaliciousFrameDetachOnUIThread(int render_process_id,
// Regression test for https://crbug.com/538784 -- ensures that one can't
// sidestep CrossSiteResourceHandler by detaching a frame mid-request.
+//
+// TODO(nick): Disabled until we re-land the fix for https://crbug.com/538784.
IN_PROC_BROWSER_TEST_F(CrossSiteResourceHandlerTest,
- NoDeliveryToDetachedFrame) {
+ DISABLED_NoDeliveryToDetachedFrame) {
GURL attacker_page = embedded_test_server()->GetURL(
"evil.com", "/cross_site_iframe_factory.html?evil(evil)");
EXPECT_TRUE(NavigateToURL(shell(), attacker_page));
« no previous file with comments | « content/browser/loader/cross_site_resource_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698