Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1398453005: Make WebPageSerializerImpl to escape URL attribute values in result. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by yosin_UTC9
Modified:
1 year, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebPageSerializerImpl to escape URL attribute values in result. This patch makes |WebPageSerializerImpl| to escape URL attribute values rather than directly output URL attribute values into result. BUG=542054 TEST=webkit_unit_tests --gtest_filter=WebPageSerializerTest.URLAttributeValues Committed: https://crrev.com/b770d85e37b2d0e248f04cf20606a2f3871ef039 Cr-Commit-Position: refs/heads/master@{#353712}

Patch Set 1 : 2015-10-13T17:51:06 #

Patch Set 2 : 2015-10-13T17:56:56 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M third_party/WebKit/Source/web/WebPageSerializerImpl.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPageSerializerTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/pageserialization/url_attribute_values.html View 1 chunk +4 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 8 (3 generated)
yosin_UTC9
PTAL This patch fixes a security bug.
1 year, 11 months ago (2015-10-13 08:55:44 UTC) #2
tkent
lgtm
1 year, 11 months ago (2015-10-13 08:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398453005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398453005/20001
1 year, 11 months ago (2015-10-13 09:01:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
1 year, 11 months ago (2015-10-13 10:00:28 UTC) #7
commit-bot: I haz the power
1 year, 11 months ago (2015-10-13 10:01:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b770d85e37b2d0e248f04cf20606a2f3871ef039
Cr-Commit-Position: refs/heads/master@{#353712}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b