Issue 1398453002: Fix Windows crash_generation_server for debug builds without -D_DEBUG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1398453002: Fix Windows crash_generation_server for debug builds without -D_DEBUG (Closed)

Created:
5 years, 2 months ago by Ted Mielczarek

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix Windows crash_generation_server for debug builds without -D_DEBUG Debug Gecko builds don't build with -D_DEBUG, so the ifdef in crash_generation_server doesn't work right. The MSDN documentation for assert says that it's enabled based on the absence of the NDEBUG define, so using that seems sensible. R=thestig@chromium.org BUG= Committed: https://chromium.googlesource.com/breakpad/breakpad/+/c53ed143108948eb7e2d7ee77dc8c0d92050ce7c

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/client/windows/crash_generation/crash_generation_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM, but there's a bunch of other _DEBUG instances laying around.

5 years, 2 months ago (2015-10-07 18:16:54 UTC) #2

Ted Mielczarek

Committed patchset #1 (id:1) manually as c53ed143108948eb7e2d7ee77dc8c0d92050ce7c (presubmit successful).

5 years, 2 months ago (2015-10-07 18:19:52 UTC) #3

Ted Mielczarek

5 years, 2 months ago (2015-10-07 18:20:07 UTC) #4

Message was sent while issue was closed.

On 2015/10/07 18:16:54, Lei Zhang wrote:
> LGTM, but there's a bunch of other _DEBUG instances laying around.

Yeah, but they're not harmful unless they're mixed with assert like this was.

Expand Messages | Collapse Messages