Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1398443006: Add a release assert to validate that it's frame pointers which are missing. (Closed)

Created:
5 years, 2 months ago by chrishtr
Modified:
5 years, 2 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a release assert to validate that it's frame pointers which are missing. BUG=540790 Committed: https://crrev.com/50de7e99f34d02e6d1c3b81624e9251d0fe36100 Cr-Commit-Position: refs/heads/master@{#353883}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chrishtr
5 years, 2 months ago (2015-10-13 20:45:48 UTC) #2
Xianzhu
lgtm
5 years, 2 months ago (2015-10-13 21:14:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398443006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398443006/20001
5 years, 2 months ago (2015-10-13 21:17:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 22:48:14 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:48:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50de7e99f34d02e6d1c3b81624e9251d0fe36100
Cr-Commit-Position: refs/heads/master@{#353883}

Powered by Google App Engine
This is Rietveld 408576698