Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1398443004: RenderFrameImpl: extract a helper function, GetRoutingIdForFrameOrProxy(). (Closed)

Created:
5 years, 2 months ago by ncarter (slow)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, Łukasz Anforowicz, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RenderFrameImpl: extract a helper function, GetRoutingIdForFrameOrProxy(). The helper returns the routing ID of the RenderFrameImpl/RenderFrameProxy associated with a remote or local WebFrame. BUG=None TEST=cq CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/8d7486dbb1438e26fddc3e9756329eeca2b56806 Cr-Commit-Position: refs/heads/master@{#353309}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -33 lines) Patch
M content/renderer/render_frame_impl.cc View 1 4 chunks +14 lines, -33 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398443004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398443004/20001
5 years, 2 months ago (2015-10-08 21:54:37 UTC) #4
ncarter (slow)
dcheng: PTAL. This pattern is starting to crop up in a few places, so it ...
5 years, 2 months ago (2015-10-08 22:14:39 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isolation/builds/374)
5 years, 2 months ago (2015-10-08 23:01:09 UTC) #8
dcheng
lgtm
5 years, 2 months ago (2015-10-08 23:49:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398443004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398443004/20001
5 years, 2 months ago (2015-10-09 15:51:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-09 16:39:30 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 16:40:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d7486dbb1438e26fddc3e9756329eeca2b56806
Cr-Commit-Position: refs/heads/master@{#353309}

Powered by Google App Engine
This is Rietveld 408576698