Issue 1398433004: The (failing) test for the invalid hint / used elements problem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1398433004: The (failing) test for the invalid hint / used elements problem. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

The (failing) test for the invalid hint / used elements problem. The problem is that during computing RESOLVED_UNIT3 we reuse RESOLVED_UNIT2 with the previously resolved bodies. And resolver ignores already resolved identifiers. So, this causes pointing to the stale element model, etc. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9f8da952179ef1b7a2d9ac06da5e48c0efa1d333

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+512 lines, -462 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/analyzer/test/src/task/dart_test.dart	View		15 chunks	+511 lines, -461 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 2 months ago (2015-10-08 04:46:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9f8da952179ef1b7a2d9ac06da5e48c0efa1d333 (presubmit successful).