Remove deprecated dart:profiler library

Remove deprecated dart:profiler library

Fixes #24510

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/535a9715ac9e8506e8fc6e9b274a1e0955738060

[Cutch, 2015-10-07 16:44:10]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2015-10-07 16:46:56]

lgtm

[Cutch, 2015-10-07 17:01:38]

Committed patchset #2 (id:20001) manually as
535a9715ac9e8506e8fc6e9b274a1e0955738060 (presubmit successful).

[Kevin Millikin (Google), 2015-10-09 10:24:48]

On 2015/10/07 17:01:38, Cutch wrote:
> Committed patchset #2 (id:20001) manually as
> 535a9715ac9e8506e8fc6e9b274a1e0955738060 (presubmit successful).

I think that this was removed too quickly, since Dart itself was using
dart:profiler in the analyzer up until 30 minutes before this change.  A ton of
stuff depends on the analyzer, sometimes transitively, and that will all be
broken in builds of the VM after this change.

We also didn't bump the analyzer version when removing import 'dart:profiler',
so it's not trivial to figure out which version to ask for to make sure you get
a version that works with a modern build of the VM.

[Cutch, 2015-10-09 13:09:10]

> I think that this was removed too quickly, since Dart itself was using
> dart:profiler in the analyzer up until 30 minutes before this change.  A ton
of
> stuff depends on the analyzer, sometimes transitively, and that will all be
> broken in builds of the VM after this change.
> 

This library has been deprecated since 1.11. All teams have had two release
cycles to stop using a deprecated library. It was supposed to be removed in 1.12
but I forgot to do it then. The alternative (dart:developer) has also been
around since 1.11 so unless someone is taking a 1.13 version of the analyzer and
running it on a 1.10 release of the VM they will be fine.

> We also didn't bump the analyzer version when removing import 'dart:profiler',
> so it's not trivial to figure out which version to ask for to make sure you
get
> a version that works with a modern build of the VM.

This is a solvable problem but bumping the sdk requirement when the next version
of the analyzer package is released.