Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: Source/core/rendering/FilterEffectRenderer.h

Issue 13984002: Extracting the SVG Filter Reference implementation out of the FilterEffectRenderer into its own typ… Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Updated to ToT, fixed style, warnings Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/FilterEffectRenderer.h
diff --git a/Source/core/rendering/FilterEffectRenderer.h b/Source/core/rendering/FilterEffectRenderer.h
index 89bfdee33a5f5f46ed9e583dc9e2c41d0dae79a4..c63397974215b1577908e77f27cc7e8655400f20 100644
--- a/Source/core/rendering/FilterEffectRenderer.h
+++ b/Source/core/rendering/FilterEffectRenderer.h
@@ -43,7 +43,6 @@
namespace WebCore {
-typedef Vector<RefPtr<FilterEffect> > FilterEffectList;
class CachedShader;
class CustomFilterProgram;
class Document;
@@ -101,7 +100,6 @@ public:
ImageBuffer* output() const { return lastEffect()->asImageBuffer(); }
bool build(RenderObject* renderer, const FilterOperations&);
- PassRefPtr<FilterEffect> buildReferenceFilter(RenderObject* renderer, PassRefPtr<FilterEffect> previousEffect, ReferenceFilterOperation*);
bool updateBackingStoreRect(const FloatRect& filterRect);
void allocateBackingStoreIfNeeded();
void clearIntermediateResults();
@@ -114,19 +112,8 @@ public:
bool hasCustomShaderFilter() const { return m_hasCustomShaderFilter; }
private:
- void setMaxEffectRects(const FloatRect& effectRect)
- {
- for (size_t i = 0; i < m_effects.size(); ++i) {
- RefPtr<FilterEffect> effect = m_effects.at(i);
- effect->setMaxEffectRect(effectRect);
- }
- }
- PassRefPtr<FilterEffect> lastEffect() const
- {
- if (m_effects.size() > 0)
- return m_effects.last();
- return 0;
- }
+ void setMaxEffectRects(const FloatRect&);
+ PassRefPtr<FilterEffect> lastEffect() const { return m_lastEffect.get(); }
FilterEffectRenderer();
virtual ~FilterEffectRenderer();
@@ -134,8 +121,8 @@ private:
FloatRect m_sourceDrawingRegion;
FloatRect m_filterRegion;
- FilterEffectList m_effects;
RefPtr<SourceGraphic> m_sourceGraphic;
+ RefPtr<FilterEffect> m_lastEffect;
IntRectExtent m_outsets;
« no previous file with comments | « Source/core/platform/graphics/filters/SkiaImageFilterBuilder.cpp ('k') | Source/core/rendering/FilterEffectRenderer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698