Decouple SSA builder from codegen-work-item

Decouple SSA builder from codegen-work-item

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac8b2af179a57255ac6d305af3aea37ca132d2b9

[Siggi Cherem (dart-lang), 2015-10-12 17:44:55]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-10-12 17:46:10]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com, sra@google.com

[Johnni Winther, 2015-10-13 07:26:27]

lgtm

https://codereview.chromium.org/1398393002/diff/20001/pkg/compiler/lib/src/en...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/1398393002/diff/20001/pkg/compiler/lib/src/en...
pkg/compiler/lib/src/enqueue.dart:778: /// All declaration elements that have
been processed by the resolver.
Thanks!

https://codereview.chromium.org/1398393002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1398393002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:1111: target.implementation);
Seems to be the invariant that [target] is already the implementation.

[Siggi Cherem (dart-lang), 2015-10-13 16:30:44]

https://codereview.chromium.org/1398393002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1398393002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:1111: target.implementation);
On 2015/10/13 07:26:27, Johnni Winther wrote:
> Seems to be the invariant that [target] is already the implementation.

Good point. done

https://codereview.chromium.org/1398393002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:1515: infoReporter?.reportInlined(element,
target);
Note: I had to change this before submitting:

The change from `compiler.currentElement -> target` was breaking a dumpinfo
test. Turns out we were updating compiler.currentELement when stepping into the
inlining stack. I updated this code to use the inlining stack directly to be
more explicit about it.

[Siggi Cherem (dart-lang), 2015-10-13 16:32:31]

Committed patchset #2 (id:30001) manually as
ac8b2af179a57255ac6d305af3aea37ca132d2b9 (presubmit successful).