Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1398383003: Add libyuv_unittest_apk target to run tests on Android (Closed)

Created:
5 years, 2 months ago by kjellander_chromium
Modified:
5 years, 2 months ago
Reviewers:
fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add libyuv_unittest_apk target to run tests on Android Roll chromium_revision bfea27a..bb79186 (340499:353481) in DEPS. Changes: https://chromium.googlesource.com/chromium/src/+log/bfea27a..bb79186 To get the Android dependencies, you need to have target_os = ["android"]; added to the end of your .gclient file (after the solution specs) + re-run gclient sync. You'll also need to run: build/install-android-sdks.sh Then build and run the test with something like this: GYP_CROSSCOMPILE=1 GYP_DEFINES="OS=android component=static_library target_arch=arm" ./gyp_libyuv ninja -C out/Release libyuv_unittest_apk util/android/test_runner.py gtest -s libyuv_unittest --verbose --release R=fbarchard@chromium.org BUG=libyuv:504 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/be4d445e8c24d5c3a7c8c6d07f9ca7b9e06b096f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -5 lines) Patch
M .gitignore View 2 chunks +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M libyuv_test.gyp View 3 chunks +40 lines, -3 lines 0 comments Download
M setup_links.py View 3 chunks +6 lines, -1 line 0 comments Download
A util/android/test_runner.py View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_chromium
Finally something that works. I ran into trouble due to some strange thing caused by ...
5 years, 2 months ago (2015-10-12 21:50:06 UTC) #2
fbarchard
lgtm
5 years, 2 months ago (2015-10-12 23:28:42 UTC) #3
fbarchard1
Committed patchset #1 (id:1) manually as be4d445e8c24d5c3a7c8c6d07f9ca7b9e06b096f (presubmit successful).
5 years, 2 months ago (2015-10-12 23:29:18 UTC) #4
kjellander_chromium
On 2015/10/12 23:29:18, fbarchard1 wrote: > Committed patchset #1 (id:1) manually as > be4d445e8c24d5c3a7c8c6d07f9ca7b9e06b096f (presubmit ...
5 years, 2 months ago (2015-10-13 06:49:21 UTC) #5
kjellander_chromium
5 years, 2 months ago (2015-10-13 07:41:27 UTC) #6
Message was sent while issue was closed.
On 2015/10/13 06:49:21, kjellander (chromium) wrote:
> On 2015/10/12 23:29:18, fbarchard1 wrote:
> > Committed patchset #1 (id:1) manually as
> > be4d445e8c24d5c3a7c8c6d07f9ca7b9e06b096f (presubmit successful).
> 
> Looks like this broke a couple of bots (trybots also didn't pass so I was
> planning on addressing that first).
> I think it's all infrastructure related, since the libyuv bots haven't gotten
> any love for a long time. I'll see if I can sort it out.

I've fixed all libyuv bots now :) Android slave needed to get new libs installed
and Windows slaves needed a bump to be able to sync past the massive Blink merge
into Chromium.

Finally the Mac ASan bots have been failing for a long time due to me
configuring them incorrectly (LSan is enabled by default for ASan, but is not
supported on Mac). That was fixed in https://codereview.chromium.org/1401313002

Powered by Google App Engine
This is Rietveld 408576698