Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398383002: core/ difference with XFA (for information only). (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

For information only. git diff origin/xfa core/ | patch -p1 -R -D PDF_ENABLE_XFA We should see how small this can me made to be.

Patch Set 1 #

Patch Set 2 : recreated #

Patch Set 3 : Re-re-created #

Patch Set 4 : Rebase. #

Patch Set 5 : regenerate #

Patch Set 6 : regenerate #

Patch Set 7 : After bidi #

Total comments: 7

Patch Set 8 : Refresh #

Patch Set 9 : Refresh, bypass hooks. #

Patch Set 10 : Closer #

Patch Set 11 : 2015-11-23 version #

Patch Set 12 : 2015-11-24 version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1500 lines, -1 line) Patch
M core/include/fpdfdoc/fpdf_doc.h View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 1 2 3 4 5 6 7 8 9 6 chunks +224 lines, -0 lines 0 comments Download
M core/include/fxcodec/fx_codec_def.h View 1 3 chunks +22 lines, -0 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 2 3 4 5 4 chunks +116 lines, -0 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 1 2 3 4 5 6 7 8 9 2 chunks +19 lines, -0 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 1 2 3 4 5 6 7 8 9 1 chunk +12 lines, -0 lines 0 comments Download
M core/include/fxcrt/fx_ucd.h View 1 2 3 4 5 6 2 chunks +150 lines, -0 lines 0 comments Download
M core/include/fxge/fx_font.h View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +85 lines, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 2 3 4 5 6 7 8 1 chunk +79 lines, -0 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 1 2 3 4 5 6 7 8 9 10 4 chunks +65 lines, -1 line 0 comments Download
M core/src/fpdftext/text_int.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 1 2 3 4 5 6 7 8 9 2 chunks +93 lines, -0 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +27 lines, -0 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +21 lines, -0 lines 0 comments Download
M core/src/fxcrt/extension.h View 1 2 3 4 5 6 7 8 9 1 chunk +34 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 1 2 3 4 5 6 7 8 1 chunk +125 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 2 3 4 5 6 7 8 2 chunks +49 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_unicode.cpp View 1 2 3 4 5 6 7 8 2 chunks +32 lines, -0 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 1 2 3 4 5 6 7 8 4 chunks +219 lines, -0 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 2 3 4 5 6 7 8 3 chunks +97 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Tom Sepez
FYI, not for landing (yet? ever?), but some of these point out unmerged refactorings ...
5 years, 2 months ago (2015-10-12 20:48:39 UTC) #2
Tom Sepez
Lei, could you take a look at this latest set, and see if anything looks ...
5 years, 1 month ago (2015-10-29 22:09:08 UTC) #5
Tom Sepez
https://codereview.chromium.org/1398383002/diff/110001/core/include/fxcodec/fx_codec.h File core/include/fxcodec/fx_codec.h (right): https://codereview.chromium.org/1398383002/diff/110001/core/include/fxcodec/fx_codec.h#newcode551 core/include/fxcodec/fx_codec.h:551: FX_BOOL FaxSkipEOL(const uint8_t* src_buf, int bitsize, int& bitpos); note: ...
5 years, 1 month ago (2015-10-29 23:07:37 UTC) #6
Tom Sepez
https://codereview.chromium.org/1398383002/diff/110001/core/src/fxcodec/codec/fx_codec_fax.cpp File core/src/fxcodec/codec/fx_codec_fax.cpp (right): https://codereview.chromium.org/1398383002/diff/110001/core/src/fxcodec/codec/fx_codec_fax.cpp#newcode284 core/src/fxcodec/codec/fx_codec_fax.cpp:284: #ifndef PDF_ENABLE_XFA note: made identical to master.
5 years, 1 month ago (2015-10-29 23:10:29 UTC) #7
Lei Zhang
https://codereview.chromium.org/1398383002/diff/110001/core/include/fxcodec/fx_codec_provider.h File core/include/fxcodec/fx_codec_provider.h (right): https://codereview.chromium.org/1398383002/diff/110001/core/include/fxcodec/fx_codec_provider.h#newcode69 core/include/fxcodec/fx_codec_provider.h:69: CFX_DIBAttribute* pAttribute = NULL) = 0; dislike https://codereview.chromium.org/1398383002/diff/110001/core/include/fxcrt/fx_basic.h File ...
5 years, 1 month ago (2015-10-30 06:15:30 UTC) #8
Tom Sepez
... and we've moved a little bit in the wrong direction with today's refresh :(.
5 years, 1 month ago (2015-11-03 00:50:20 UTC) #9
Lei Zhang
On 2015/11/03 00:50:20, Tom Sepez wrote: > ... and we've moved a little bit in ...
5 years, 1 month ago (2015-11-03 01:02:46 UTC) #10
Tom Sepez
Hey Lei, I think all that remains is some of the bidi stuff? Want to ...
5 years, 1 month ago (2015-11-23 18:50:00 UTC) #11
Lei Zhang
5 years, 1 month ago (2015-11-23 19:00:35 UTC) #12 
On 2015/11/23 18:50:00, Tom Sepez wrote:
> Hey Lei, I think all that remains is some of the bidi stuff? Want to take a
stab
> at this prior to inflicting this on xfa, or after?

I think I've taken care of all that I can. Everything that remains is being used
by xfa/.

Powered by Google App Engine
This is Rietveld 408576698