Issue 139833006: [FileAPI] Ignore requests after QuotaReservation::OnClientCrash call. (2/6)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139833006: [FileAPI] Ignore requests after QuotaReservation::OnClientCrash call. (2/6) (Closed)

Created:
6 years, 11 months ago by tzik

Modified:
6 years, 11 months ago

Reviewers:
bbudge

CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[FileAPI] Ignore requests after QuotaReservation::OnClientCrash call. When a client crash detected, the associated QuotaReservation object reclaims its reserved quota. And then, in-flight operations should be ignored. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245481

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
	M	webkit/browser/fileapi/quota/quota_reservation.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	webkit/browser/fileapi/quota/quota_reservation.cc	View		6 chunks	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tzik

Hi, Bill. Can I make another fix for plugin crash case? The test for this ...

6 years, 11 months ago (2014-01-16 07:05:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/139833006/1

6 years, 11 months ago (2014-01-17 03:09:49 UTC) #3

Message was sent while issue was closed.

Change committed as 245481

Expand Messages | Collapse Messages