Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: remoting/codec/video_encoder.h

Issue 13983010: Use webrtc::DesktopCapturer for screen capturer implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: q Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/codec/video_encoder.h
diff --git a/remoting/codec/video_encoder.h b/remoting/codec/video_encoder.h
index 81179c4da0862f9acb94f0abad069300d56df3d6..7520b454fe330ae15fbe12760e8f5f00a0f5a113 100644
--- a/remoting/codec/video_encoder.h
+++ b/remoting/codec/video_encoder.h
@@ -7,11 +7,12 @@
#include "base/basictypes.h"
#include "base/callback.h"
-#include "media/base/data_buffer.h"
-namespace media {
-class ScreenCaptureData;
-} // namespace media
+class SkRegion;
+
+namespace webrtc {
+class DesktopFrame;
+} // namespace webrtc
namespace remoting {
@@ -29,15 +30,10 @@ class VideoEncoder {
virtual ~VideoEncoder() {}
- // Encode an image stored in |capture_data|.
- //
- // If |key_frame| is true, the encoder should not reference
- // previous encode and encode the full frame.
- //
- // When encoded data is available, partial or full |data_available_callback|
- // is called.
- virtual void Encode(scoped_refptr<media::ScreenCaptureData> capture_data,
- bool key_frame,
+ // Encode an image stored in |frame|. Doesn't take ownership of |frame|. When
+ // encoded data is available, partial or full |data_available_callback| is
+ // called.
Wez 2013/04/26 18:48:14 IIRC the implementations are synchronous, so you c
Sergey Ulanov 2013/05/07 22:25:50 Not related to this CL.
+ virtual void Encode(webrtc::DesktopFrame* frame,
Wez 2013/04/26 18:48:14 If this isn't being passed, it can be const Deskto
Sergey Ulanov 2013/05/07 22:25:50 Done.
const DataAvailableCallback& data_available_callback) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698