Remove print and move bookmark to the top of the action box.

chrome/browser/ui/toolbar/action_box_button_controller.h

Index: chrome/browser/ui/toolbar/action_box_button_controller.h
diff --git a/chrome/browser/ui/toolbar/action_box_button_controller.h b/chrome/browser/ui/toolbar/action_box_button_controller.h
index 94820440deb2daad7b7724ab54a5acc1d1355667..f61af212bc97481f44cf41f70ee9dd2252402079 100644
--- a/chrome/browser/ui/toolbar/action_box_button_controller.h
+++ b/chrome/browser/ui/toolbar/action_box_button_controller.h
@@ -44,6 +44,10 @@ class ActionBoxButtonController : public ui::SimpleMenuModel::Delegate,
   ActionBoxButtonController(Browser* browser, Delegate* delegate);
   virtual ~ActionBoxButtonController();
 
+  // Creates and populates an ActionBoxMenuModel according to the current
+  // state of the browser.
+  scoped_ptr<ActionBoxMenuModel> CreateMenuModel();

[Mike Wittman, 2013/04/10 20:44:04]

make private and expose via a test api.  see e.g. ui::Event::TestApi

[Rune Fevang, 2013/04/10 21:17:48]

I've ended up adding this function a couple of times (for now abandoned CLs), so
the main motivation for adding it was not to facilitate testing (I could have
called OnButtonClicked and implemented ShowMenu for that).

I actually considered getting rid of the Delegate class and OnButtonClicked and
having callers instead calling CreateMenuModel and showing the menu themselves.
What do you think? I didn't do it because I wasn't really sure why it was done
this way in the first place, and was worried it was wrong from an idealized MVC
perspective.

[Mike Wittman, 2013/04/10 22:16:01]

The delegate doesn't appear to be providing a lot of value in the current code. 
But if the controller were to get more complicated, it seems like a useful
mechanism to separate the cross-platform and platform-dependent input handling.

+
   // Notifies this that the action box button has been clicked.
   // Methods on the Delegate may be called re-entrantly.
   void OnButtonClicked();