Move the wire protocol support into the public API

Move the wire protocol support into the public API

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ad256cf18bc086e27a32e0e5fa8a6a694a36d1a

[Brian Wilkerson, 2015-10-10 20:56:55]

brianwilkerson@google.com changed reviewers:
+ danrubel@google.com, paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2015-10-10 20:56:56]

Sorry about the size of the CL. All of the changes outside of 'protocol.dart',
'generated_protocol.dart' and 'protocol_internal.dart' are updates of imports
and formatting/sorting changes.

I took the old 'protocol.dart' and split it into two libraries: a public library
(still named 'protocol.dart', but in a public location, and a private library
named 'protocol_internal.dart'. I renamed many of the previously private
functions and classes to have public names so that they could be imported. I
also cleaned up the comments in 'protocol.dart' and added a "do not subtype this
class" warning to all of the classes in both 'protocol.dart' and
'generated_protocol.dart'.

Let me know if there's anything in the public API that you think shouldn't be
there or if there's anything you think should be there that's missing.

[Paul Berry, 2015-10-10 23:08:35]

lgtm

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/plugin/protocol/protocol.dart (right):

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/plugin/protocol/protocol.dart:41: * Clients are not
expected to subtype this class.
Suggestion: rephrase this to "Clients should not subtype this class."  Some
people (myself included) read "not expected to" as "you may do so, but you are
not required to".  Which I think is not what you mean :)

[scheglov, 2015-10-10 23:22:59]

LGTM

[Brian Wilkerson, 2015-10-11 14:34:35]

Committed patchset #2 (id:20001) manually as
9ad256cf18bc086e27a32e0e5fa8a6a694a36d1a (presubmit successful).

[Brian Wilkerson, 2015-10-11 14:36:53]

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/plugin/protocol/protocol.dart (right):

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/plugin/protocol/protocol.dart:41: * Clients are not
expected to subtype this class.
No, that's not what I mean. I'll address in a follow-on CL.

[Paul Berry, 2015-10-12 12:32:10]

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/integration/integration_test_methods.dart (left):

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/integration/integration_test_methods.dart:5: // This
file has been automatically generated.  Please do not edit it manually.
It turns out this is an autogenerated file which it looks like you manually
edited, causing the test "pkg/analysis_server/tool/spec/check_all_test" to fail.
 I'm working on a fix.

[Paul Berry, 2015-10-12 12:44:52]

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/integration/integration_test_methods.dart (left):

https://codereview.chromium.org/1398293002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/integration/integration_test_methods.dart:5: // This
file has been automatically generated.  Please do not edit it manually.
On 2015/10/12 12:32:10, Paul Berry wrote:
> It turns out this is an autogenerated file which it looks like you manually
> edited, causing the test "pkg/analysis_server/tool/spec/check_all_test" to
fail.
>  I'm working on a fix.

Fix is here: https://codereview.chromium.org/1397353002/