Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139823003: Mojo: Move system embedder API files to mojo/system/embedder. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Move system embedder API files to mojo/system/embedder. (More changes to come -- in particular to reduce exports from mojo_system_impl -- but one thing at a time....) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -703 lines) Patch
M mojo/common/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/multiprocess_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/multiprocess_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/multiprocess_test_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 4 chunks +13 lines, -11 lines 0 comments Download
M mojo/shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/channel.h View 1 chunk +1 line, -1 line 0 comments Download
D mojo/system/embedder.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/system/embedder.cc View 1 chunk +0 lines, -91 lines 0 comments Download
A + mojo/system/embedder/embedder.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/system/embedder/embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/system/embedder/embedder_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/system/embedder/platform_channel_pair.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/system/embedder/platform_channel_pair.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/system/embedder/platform_channel_pair_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/system/embedder/platform_handle.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/system/embedder/platform_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/system/embedder/scoped_platform_handle.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/system/embedder/test_embedder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/system/embedder/test_embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/system/embedder_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/system/platform_channel_pair.h View 1 chunk +0 lines, -73 lines 0 comments Download
D mojo/system/platform_channel_pair.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/system/platform_channel_pair_posix.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D mojo/system/platform_handle.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/system/platform_handle.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/system/raw_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel_posix_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/remote_message_pipe_posix_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/system/scoped_platform_handle.h View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/system/test_embedder.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/system/test_embedder.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 11 months ago (2014-01-16 21:18:59 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-16 21:22:58 UTC) #2
viettrungluu
6 years, 11 months ago (2014-01-16 21:48:20 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r245339 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698