Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: tracing/tracing/core/scripting_controller.html

Issue 1398213005: tquery: Remove hard dependency on UI (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Review comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/core/scripting_controller.html
diff --git a/tracing/tracing/core/scripting_controller.html b/tracing/tracing/core/scripting_controller.html
index ebeaf182a0217412c65b6ea02e3ab130cb996507..df509708c1923d816201c2c1edc191a89af488c2 100644
--- a/tracing/tracing/core/scripting_controller.html
+++ b/tracing/tracing/core/scripting_controller.html
@@ -25,7 +25,7 @@ tr.exportTo('tr.c', function() {
this.addScriptObject(typeInfo.metadata.name, typeInfo.constructor);
// Also make the object available to the DevTools inspector.
global[typeInfo.metadata.name] = typeInfo.constructor;
- }.bind(this));
+ }, this);
}
function ScriptingObjectRegistry() {
@@ -41,8 +41,8 @@ tr.exportTo('tr.c', function() {
onModelChanged_: function() {
this.scriptObjectValues_.forEach(function(v) {
if (v.onModelChanged)
- v.onModelChanged();
- });
+ v.onModelChanged(this.brushingStateController.model);
+ }.bind(this));
},
addScriptObject: function(name, value) {
« no previous file with comments | « no previous file | tracing/tracing/core/scripting_object.html » ('j') | tracing/tracing/core/scripting_object.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698