Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398213003: Refactored Non-SFI and SFI NaCl into separate directories. (Closed)

Created:
5 years, 2 months ago by Sean Klein
Modified:
5 years, 2 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Refactored Non-SFI and SFI NaCl into separate directories. - Created mojo/nacl/nonsfi - Added nonsfi-specific README.md - Created mojo/nacl/sfi - Updated sfi-specific README.md - Moved nacl_bindings_generator into this directory - Moved nacl_bindings into this directory - Split the mojo/nacl/BUILD.gn file into three parts - A shared SFI + Non-SFI BUILD file, at mojo/nacl - A SFI BUILD file, at mojo/nacl/sfi - A Non-SFI BUILD file, at mojo/nacl/nonsfi - Updated BUILD.gn files with relevant paths - Updated #includes with relevant paths - PRESUBMIT.py was angry about printf-s from an SFI NaCl file, so I gave it permission to spam the console (it's about unimplemented features of SFI NaCl, so "spamming" stderr seems OK to me). BUG=https://github.com/domokit/mojo/issues/396 R=mseaborn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/298d9942de7819c4a837b049bc98d2cbcd61554f

Patch Set 1 : #

Total comments: 16

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -3066 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/nacl/BUILD.gn View 2 chunks +0 lines, -170 lines 0 comments Download
D mojo/nacl/README.md View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/nacl/irt_mojo_nonsfi.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/nacl/irt_mojo_nonsfi.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/nacl/monacl_shell.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/nacl/monacl_shell_nonsfi.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/nacl/nexe_launcher_nonsfi.h View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/nacl/nexe_launcher_nonsfi.cc View 1 chunk +0 lines, -30 lines 0 comments Download
A + mojo/nacl/nonsfi/BUILD.gn View 5 chunks +1 line, -67 lines 0 comments Download
A mojo/nacl/nonsfi/README.md View 1 1 chunk +63 lines, -0 lines 0 comments Download
A + mojo/nacl/nonsfi/irt_mojo_nonsfi.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/nacl/nonsfi/monacl_shell_nonsfi.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/nacl/nonsfi/nexe_launcher_nonsfi.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/nacl/nonsfi/nexe_launcher_nonsfi.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/nacl/sfi/BUILD.gn View 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/nacl/sfi/README.md View 1 1 chunk +41 lines, -0 lines 0 comments Download
A + mojo/nacl/sfi/monacl_shell.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/irt_entry_mojo.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/mojo_syscall.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/mojo_syscall_internal.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/monacl_sel_main.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings/monacl_sel_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings_generator/generate_nacl_bindings.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings_generator/interface.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings_generator/interface_dsl.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings_generator/libmojo.cc.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings_generator/mojo_irt.c.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings_generator/mojo_irt.h.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/nacl/sfi/nacl_bindings_generator/mojo_syscall.cc.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
D nacl_bindings/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D nacl_bindings/irt_entry_mojo.c View 1 chunk +0 lines, -21 lines 0 comments Download
D nacl_bindings/mojo_irt.c View 1 chunk +0 lines, -357 lines 0 comments Download
D nacl_bindings/mojo_syscall.h View 1 chunk +0 lines, -21 lines 0 comments Download
D nacl_bindings/mojo_syscall.cc View 1 chunk +0 lines, -730 lines 0 comments Download
D nacl_bindings/mojo_syscall_internal.h View 1 chunk +0 lines, -238 lines 0 comments Download
D nacl_bindings/monacl_sel_main.h View 1 chunk +0 lines, -25 lines 0 comments Download
D nacl_bindings/monacl_sel_main.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D nacl_bindings_generator/generate_nacl_bindings.py View 1 chunk +0 lines, -563 lines 0 comments Download
D nacl_bindings_generator/interface.py View 1 chunk +0 lines, -134 lines 0 comments Download
D nacl_bindings_generator/interface_dsl.py View 1 chunk +0 lines, -154 lines 0 comments Download
D nacl_bindings_generator/libmojo.cc.tmpl View 1 chunk +0 lines, -35 lines 0 comments Download
D nacl_bindings_generator/mojo_irt.c.tmpl View 1 chunk +0 lines, -43 lines 0 comments Download
D nacl_bindings_generator/mojo_irt.h.tmpl View 1 chunk +0 lines, -31 lines 0 comments Download
D nacl_bindings_generator/mojo_syscall.cc.tmpl View 1 chunk +0 lines, -110 lines 0 comments Download
M services/nacl/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M services/nacl/content_handler_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/content_handler_main_nonsfi.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Sean Klein
Figured this would help clean Mojo NaCl up a little bit. I was also just ...
5 years, 2 months ago (2015-10-12 16:16:12 UTC) #3
Mark Seaborn
LGTM https://codereview.chromium.org/1398213003/diff/20001/mojo/nacl/nonsfi/README.md File mojo/nacl/nonsfi/README.md (right): https://codereview.chromium.org/1398213003/diff/20001/mojo/nacl/nonsfi/README.md#newcode27 mojo/nacl/nonsfi/README.md:27: $ ./native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-translate How about adding a "\" to ...
5 years, 2 months ago (2015-10-12 17:18:50 UTC) #4
Sean Klein
https://codereview.chromium.org/1398213003/diff/20001/mojo/nacl/nonsfi/README.md File mojo/nacl/nonsfi/README.md (right): https://codereview.chromium.org/1398213003/diff/20001/mojo/nacl/nonsfi/README.md#newcode27 mojo/nacl/nonsfi/README.md:27: $ ./native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-translate On 2015/10/12 17:18:50, Mark Seaborn wrote: > ...
5 years, 2 months ago (2015-10-12 19:10:44 UTC) #5
Sean Klein
5 years, 2 months ago (2015-10-12 19:19:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
298d9942de7819c4a837b049bc98d2cbcd61554f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698