Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: editor/analyzer.gyp

Issue 13982010: Use intermediate file containing javac arguments to overcome windows limitations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/analyzer.gyp
diff --git a/editor/analyzer.gyp b/editor/analyzer.gyp
index 5fb12e9748a1edf0cf9a146b81ab3e25c4c0da03..b23cd7cd899c10cb0052c7ef4c5265f6e7820fd5 100644
--- a/editor/analyzer.gyp
+++ b/editor/analyzer.gyp
@@ -3,6 +3,11 @@
# BSD-style license that can be found in the LICENSE file.
{
+ 'includes' : [
+ # These files are generated by 'gclient runhooks'.
+ 'plugin_command_analyze_sources.gypi',
+ 'plugin_engine_sources.gypi',
+ ],
'variables': {
'analyzer_name': 'dartanalyzer',
# When changing the jar files that we depend on please change the list
@@ -19,10 +24,6 @@
'target_name': 'analyzer',
'type': 'none',
'variables': {
- 'java_source_files': [
- '<!@(["python", "../tools/list_files.py", "\\.java$", "tools/plugins/com.google.dart.command.analyze"])',
- '<!@(["python", "../tools/list_files.py", "\\.java$", "tools/plugins/com.google.dart.engine"])',
- ],
# The file where we write the class path to be used in the manifest.
'class_path_file': '<(PRODUCT_DIR)/<(analyzer_name)/classpath_file',
},
@@ -30,9 +31,12 @@
{
'action_name': 'create_analyzer',
'inputs': [
- '<@(java_source_files)',
+ '<@(plugin_command_analyze_java_sources)',
+ '<@(plugin_engine_java_sources)',
'<@(dependent_jar_files)',
'tools/compile_analyzer.py',
+ 'plugin_command_analyze_sources.gypi',
+ 'plugin_engine_sources.gypi',
],
'outputs': [
'<(PRODUCT_DIR)/<(analyzer_name)/<(analyzer_name).jar',
@@ -46,7 +50,11 @@
'--dependent_jar_files', '"<@(dependent_jar_files)"',
'--entry_point', 'com.google.dart.command.analyze.AnalyzerMain',
'--class_path_file', 'classpath_file',
- '<@(java_source_files)',
+ # These files are generated by 'gclient runhooks'.
+ # The '@filename' will instruct javac to read 'filename' and treat
+ # every line as an additional commandline argument.
+ '@plugin_command_analyze_sources.txt',
+ '@plugin_engine_sources.txt',
],
'message': 'Creating <(_outputs).',
},

Powered by Google App Engine
This is Rietveld 408576698